Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove didInitAttrs lifecycle method #15923

Merged
merged 2 commits into from
Dec 5, 2017

Conversation

thoov
Copy link
Member

@thoov thoov commented Dec 5, 2017

Apart of: #15876

Related: ember-2-legacy PR

@@ -70,7 +70,6 @@ export default Mixin.create({
concatenatedProperties: ['attributeBindings'],

[POST_INIT]() {
this.trigger('didInitAttrs');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be ENV wrapped, otherwise users in the addon will not ever have their didInitAttrs get invoked...

Copy link
Member Author

@thoov thoov Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue Oops forgot about that. You are right. Let me add that

@thoov
Copy link
Member Author

thoov commented Dec 5, 2017

@rwjblue addressed your comment

@rwjblue rwjblue merged commit d5f57aa into emberjs:master Dec 5, 2017
@rwjblue
Copy link
Member

rwjblue commented Dec 5, 2017

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants