Remove this.resource from RouterDSL #15883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is exposed as |
rwjblue
reviewed
Nov 29, 2017
| @@ -18,7 +18,6 @@ QUnit.module('Ember Router DSL', { | |||
| }); | |||
|
|
|||
| QUnit.test('should fail when using a reserved route name', function() { | |||
| expectDeprecation('this.resource() is deprecated. Use this.route(\'name\', { resetNamespace: true }, function () {}) instead.'); | |||
| let reservedNames = ['array', 'basic', 'object', 'application']; | |||
|
|
|||
| expect((reservedNames.length * 2) + 1); | |||
There was a problem hiding this comment.
Need to tweak this somewhat, the CI failure is due to it thinking it has 9 assertions and only actually getting 5
locks
force-pushed
the
remove-router-dsl-resource
branch
from
c2e30e8
to
430621f
Compare
locks
force-pushed
the
remove-router-dsl-resource
branch
2 times, most recently
from
6f06a13
to
51e3967
Compare
|
@locks - Needs a rebase... |
locks
force-pushed
the
remove-router-dsl-resource
branch
from
51e3967
to
587c3fc
Compare
|
@rwjblue rebased |
locks
force-pushed
the
remove-router-dsl-resource
branch
from
587c3fc
to
f791428
Compare
locks
force-pushed
the
remove-router-dsl-resource
branch
from
f791428
to
7f97511
Compare
rwjblue
approved these changes
Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.