Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize Library] Align visualizations links to the left in Safari #92374

Merged

Conversation

sulemanof
Copy link
Contributor

Summary

Fixes #92176

Fixes wrong alignment of visualizations links in Safari browser.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and fixes the bug, thanx Daniil ❤️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualize 98.9KB 99.1KB +263.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0 labels Feb 23, 2021
@sulemanof sulemanof marked this pull request as ready for review February 23, 2021 13:28
@sulemanof sulemanof requested a review from a team February 23, 2021 13:28
@sulemanof sulemanof requested a review from a team as a code owner February 23, 2021 13:28
@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EuiBasicTable provides an align prop when defining columns. Has this been tried?
If so, and it does not work, then an EUI issue would need to be created.

image

@sulemanof
Copy link
Contributor Author

EuiBasicTable provides an align prop when defining columns. Has this been tried?
If so, and it does not work, then an EUI issue would need to be created.

The column is left aligned by default. Setting align: 'left' explicitly doesn't have any effect.
The problem is only in Safari browser when text takes space more than one row.

notice, that only text with word-wrap is not aligned well:

image

The problem appeared when the link was wrapped with additional <div>, which comes from RedirectAppLinks component.

image

@ryankeairns ryankeairns self-requested a review February 23, 2021 17:57
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I did some further testing and opened an EUI issue to fix the default state.

@sulemanof sulemanof merged commit 698a06a into elastic:master Feb 24, 2021
@sulemanof sulemanof deleted the fix/visualize_listing_align_links branch February 24, 2021 08:09
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Feb 24, 2021
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Feb 24, 2021
sulemanof pushed a commit that referenced this pull request Feb 24, 2021
sulemanof pushed a commit that referenced this pull request Feb 24, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 25, 2021
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits)
  Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578)
  [Uptime] Search made easy (elastic#88581)
  [Lens] Stop requesting stats on Records field (elastic#92508)
  [APM] Correlations style polish in prep for release (elastic#92514)
  [Lens] Fix sorting undefined, null and NaN values (elastic#92575)
  Put environment back in uiFilters (elastic#92561)
  [Discover] Fix sorting by _score behavior (elastic#92132)
  Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290)
  [Usage Collection] Remove unused UI Metric APIs (elastic#91620)
  Fix timelion deprecation documentation links (elastic#92576)
  [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395)
  Fix text align in Safari (elastic#92374)
  [Actions][Doc] Clean up Actions README (elastic#91789)
  chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506)
  [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047)
  Revert "[build] Add task skips intended for partial builds (elastic#92076)"
  [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527)
  [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787)
  [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348)
  [DOCS] Updates refresh text in index pattern doc (elastic#92469)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Visualize Library] Titles are centered horizontally on Safari
5 participants