Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet #92047

Merged
merged 8 commits into from
Feb 24, 2021
Merged

[Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet #92047

merged 8 commits into from
Feb 24, 2021

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Feb 19, 2021 •
edited
Loading

Summary

  • sticky bottom bar to save vs. the saving at top
  • page margins should match Fleet Policy page

Screenshots
image

With advanced settings closed
image

With advanced settings opened
image

@parkiino parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Endpoint Elastic Endpoint feature Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.13.0 labels Feb 19, 2021
@parkiino parkiino requested a review from a team as a code owner February 19, 2021 17:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@elasticmachine
Copy link
Contributor

Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint)

@kevinlog
Copy link
Contributor

I checked it out and noticed a few things:

  1. We need to account for the bottom bar here, some of the content is cut off. Extra padding may work
  2. The "Save" button should be the blue color like it is on the Fleet page

image

  1. The margin still looks wider on our view vs Fleet. I noticed in Fleet they have a max-width: 770px on the content area for the policy, we could do something similar in ours so that we match.

Fleet:
image

Max width:
image

Nice job accounting for the Policy header and background color! Just address the above and I'll 👍

@parkiino
Copy link
Contributor Author

@elasticmachine merge upstream

paul-tavares
paul-tavares approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checked it out loacally and ran it from endpoint side as well as fleet side (to ensure form was good)

@parkiino
Copy link
Contributor Author

@elasticmachine merge upstream

@parkiino
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / Deletes and recovers more than one rule.Deleting prebuilt rules Deletes and recovers more than one rule

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: expected '<button.euiButton.euiButton--primary>' to have text 'Install 2 Elastic prebuilt rules ', but the text was 'Install 1 Elastic prebuilt rule '
    at Context.eval (http://localhost:61211/__cypress/tests?p=cypress/integration/detection_rules/prebuilt_rules.spec.ts:20260:68)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2203 2202 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.7MB 7.7MB +260.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino merged commit 048425d into elastic:master Feb 24, 2021
@parkiino parkiino deleted the task/match-fleet branch February 24, 2021 01:58
@parkiino parkiino mentioned this pull request Feb 24, 2021
Merged
parkiino added a commit that referenced this pull request Feb 24, 2021
@parkiino
[Security Solution][Endpoint][Admin] Match Policy Details in Security…
efa4da0 
… Solution with Fleet (#92047) (#92554)
@parkiino parkiino mentioned this pull request Feb 24, 2021
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 25, 2021
@gmmorris
Merge branch 'task-manager/docs-monitoring' of github.com:gmmorris/ki…
26bdc8d 
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits)
  Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578)
  [Uptime] Search made easy (elastic#88581)
  [Lens] Stop requesting stats on Records field (elastic#92508)
  [APM] Correlations style polish in prep for release (elastic#92514)
  [Lens] Fix sorting undefined, null and NaN values (elastic#92575)
  Put environment back in uiFilters (elastic#92561)
  [Discover] Fix sorting by _score behavior (elastic#92132)
  Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290)
  [Usage Collection] Remove unused UI Metric APIs (elastic#91620)
  Fix timelion deprecation documentation links (elastic#92576)
  [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395)
  Fix text align in Safari (elastic#92374)
  [Actions][Doc] Clean up Actions README (elastic#91789)
  chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506)
  [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047)
  Revert "[build] Add task skips intended for partial builds (elastic#92076)"
  [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527)
  [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787)
  [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348)
  [DOCS] Updates refresh text in index pattern doc (elastic#92469)
  ...
parkiino added a commit that referenced this pull request Mar 1, 2021
@parkiino
[Security Solution][Endpoint][Admin] Match Policy Details in Security…
fdefa62 
… Solution with Fleet (#92047) (#92640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parkiino @elasticmachine @kevinlog @kibanamachine @paul-tavares