-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix sorting by _score behavior #92132
[Discover] Fix sorting by _score behavior #92132
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and compared against 7.11- it seems like this was already the default behavior before?
Anyway LGTM, but probably needs a second reviewer
it was, but due to changes after 7.11 it wasn't anymore, so I might rewrite the title 'Improve' which is misleading |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and works correctly (also not clear to me when was it removed in the first place).
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits) Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578) [Uptime] Search made easy (elastic#88581) [Lens] Stop requesting stats on Records field (elastic#92508) [APM] Correlations style polish in prep for release (elastic#92514) [Lens] Fix sorting undefined, null and NaN values (elastic#92575) Put environment back in uiFilters (elastic#92561) [Discover] Fix sorting by _score behavior (elastic#92132) Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290) [Usage Collection] Remove unused UI Metric APIs (elastic#91620) Fix timelion deprecation documentation links (elastic#92576) [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395) Fix text align in Safari (elastic#92374) [Actions][Doc] Clean up Actions README (elastic#91789) chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506) [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047) Revert "[build] Add task skips intended for partial builds (elastic#92076)" [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527) [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787) [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348) [DOCS] Updates refresh text in index pattern doc (elastic#92469) ...
Summary
The integration of EuiDataGrid made it necessary to allow the user to un-sort Discover's document table. (#85561) Default sorting of index patterns without time field sorted internally still by
_score
, but when the user added the_score
column, there was no indication that's it's sorted. This PR solves it by automatically adding sorting by_score
when the user selects the column, if she/he didn't sort it before by a different field. This also works when adding _score using an index pattern with timefield and it's in an unsorted state. Also this PR increased test coverageTesting
_score
columnsort_by_score.mp4
Checklist