Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. #91787

Merged
merged 15 commits into from
Feb 23, 2021
Merged

[Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. #91787

merged 15 commits into from
Feb 23, 2021
+177 −156

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Feb 18, 2021 •
edited
Loading

Resolves #80632

Test link https://kibana_91787.docs-preview.app.elstc.co/guide/en/kibana/master/alert-types.html

  • Documentation was added for features that require explanation or tutorials

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v7.12.0 labels Feb 18, 2021
@YulNaumenko YulNaumenko self-assigned this Feb 18, 2021
@YulNaumenko YulNaumenko requested a review from a team as a code owner February 18, 2021 01:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1
ymao1 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gchaps
gchaps reviewed Feb 18, 2021
View reviewed changes
docs/user/alerting/alert-types.asciidoc Outdated
@@ -1,159 +1,28 @@
[role="xpack"]
[[alert-types]]
== Standard stack alert types
== Alert types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about removing the word "type" from the headings. I don't feel that it adds any value. So the navigation would look like this:

  • Actions and connectors
  • Alerts
    Index threshold
    ES query

Copy link
Contributor Author

@YulNaumenko YulNaumenko Feb 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree 👍

docs/user/alerting/alert-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/alert-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/alert-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/alert-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/alert-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/alert-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/alert-types.asciidoc Show resolved Hide resolved
docs/user/alerting/alerting-getting-started.asciidoc Outdated Show resolved Hide resolved
docs/management/alerting/alert-management.asciidoc Outdated Show resolved Hide resolved
gchaps
gchaps approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 23, 2021 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [b1eac3c]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko merged commit 561a267 into elastic:master Feb 23, 2021
@YulNaumenko YulNaumenko mentioned this pull request Feb 23, 2021
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Feb 23, 2021
@YulNaumenko @gchaps
[Alerts][Docs] Alert types doc update. Added refs to applications spe…
832aa7c 
…cific alerts groups. (elastic#91787)

* [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups.

* fixed ci

* fixed ci

* fixed ci

* fixed ci

* fixed alignment of pages

* fixed addtional links

* fixed titles

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/management/alerting/alert-management.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* renamed titles

* moved maps to own folder

* renamed titles

* removed mistake file

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Feb 23, 2021
@YulNaumenko @gchaps
[Alerts][Docs] Alert types doc update. Added refs to applications spe…
ca88d3a 
…cific alerts groups. (elastic#91787)

* [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups.

* fixed ci

* fixed ci

* fixed ci

* fixed ci

* fixed alignment of pages

* fixed addtional links

* fixed titles

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/management/alerting/alert-management.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* renamed titles

* moved maps to own folder

* renamed titles

* removed mistake file

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@YulNaumenko YulNaumenko mentioned this pull request Feb 23, 2021
Merged
YulNaumenko added a commit that referenced this pull request Feb 23, 2021
@YulNaumenko @gchaps
[Alerts][Docs] Alert types doc update. Added refs to applications spe…
63e3847 
…cific alerts groups. (#91787) (#92537)

* [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups.

* fixed ci

* fixed ci

* fixed ci

* fixed ci

* fixed alignment of pages

* fixed addtional links

* fixed titles

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/management/alerting/alert-management.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* renamed titles

* moved maps to own folder

* renamed titles

* removed mistake file

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
YulNaumenko added a commit that referenced this pull request Feb 23, 2021
@YulNaumenko @gchaps
[Alerts][Docs] Alert types doc update. Added refs to applications spe…
5a8a8d1 
…cific alerts groups. (#91787) (#92538)

* [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups.

* fixed ci

* fixed ci

* fixed ci

* fixed ci

* fixed alignment of pages

* fixed addtional links

* fixed titles

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/management/alerting/alert-management.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* renamed titles

* moved maps to own folder

* renamed titles

* removed mistake file

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@YulNaumenko YulNaumenko mentioned this pull request Feb 24, 2021
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 25, 2021
@gmmorris
Merge branch 'task-manager/docs-monitoring' of github.com:gmmorris/ki…
26bdc8d 
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits)
  Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578)
  [Uptime] Search made easy (elastic#88581)
  [Lens] Stop requesting stats on Records field (elastic#92508)
  [APM] Correlations style polish in prep for release (elastic#92514)
  [Lens] Fix sorting undefined, null and NaN values (elastic#92575)
  Put environment back in uiFilters (elastic#92561)
  [Discover] Fix sorting by _score behavior (elastic#92132)
  Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290)
  [Usage Collection] Remove unused UI Metric APIs (elastic#91620)
  Fix timelion deprecation documentation links (elastic#92576)
  [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395)
  Fix text align in Safari (elastic#92374)
  [Actions][Doc] Clean up Actions README (elastic#91789)
  chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506)
  [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047)
  Revert "[build] Add task skips intended for partial builds (elastic#92076)"
  [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527)
  [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787)
  [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348)
  [DOCS] Updates refresh text in index pattern doc (elastic#92469)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@gchaps gchaps gchaps approved these changes

@kindsun kindsun Awaiting requested review from kindsun

Assignees

@YulNaumenko YulNaumenko

Labels
docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert types doc update
6 participants
@YulNaumenko @elasticmachine @kibanamachine @kindsun @ymao1 @gchaps