-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Search made easy #88581
[Uptime] Search made easy #88581
Conversation
While I like this feature, I'm reticent to include step names in the search because it's not obvious looking at the result what matched. |
@elasticmachine merge upstream |
@andrewvc i understand your point, it's always a tricky user experience searching against a data which isn't displayed on UI. I am going to hold off on adding new field for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When typing a search phrase, if you hit enter, the search is executed but the search term disappears in the search box. It then becomes unclear how to remove the search term. If you refresh the page, the search term appears in the search box and can be removed with the x symbol.
Also, when switching between simple search and KQL, if you switch back to simple search it no longer appears to find results properly. Below, I used a unique monitor id to match a monitor, then switched to KQL and immediately back to simple search. The search term then no longer worked appropriately
Also, the menu button that opens the popover to switch between KQL and simple search is not tabable or accessible by a keyboard
@dominiqueclarke great catch, i have fixed and updated key events. |
Thanks! The fix looks great! I'm still seeing these issues
To recreate issue number 1. |
Discussed in refinement, this implementation won't include step names (that could be a future enhancement if there's a use case for it) |
@dominiqueclarke have fixed the toggle issue |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits) Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578) [Uptime] Search made easy (elastic#88581) [Lens] Stop requesting stats on Records field (elastic#92508) [APM] Correlations style polish in prep for release (elastic#92514) [Lens] Fix sorting undefined, null and NaN values (elastic#92575) Put environment back in uiFilters (elastic#92561) [Discover] Fix sorting by _score behavior (elastic#92132) Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290) [Usage Collection] Remove unused UI Metric APIs (elastic#91620) Fix timelion deprecation documentation links (elastic#92576) [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395) Fix text align in Safari (elastic#92374) [Actions][Doc] Clean up Actions README (elastic#91789) chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506) [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047) Revert "[build] Add task skips intended for partial builds (elastic#92076)" [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527) [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787) [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348) [DOCS] Updates refresh text in index pattern doc (elastic#92469) ...
Summary
Fixes: elastic/uptime#274
User can search for monitors using kuery bar in a simple mode, entered query will be automatically searched against monitorid, name and url.
It uses elastic search multi match phrase_prefix query to perform search.
User will not have to know ecs schema to perform search
this also means user can user include text to search against any text appearing anywhere in those fields, which is not possible in kuery bar.
User can switch to KQL mode using a simple popover
Questions