fix: stay on page after version switch #679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #678
I believe this fixes the version switch only for version 2.2, when switching to any other version, but not vice versa.
Additional PRs would have to backport this fix into gh-pages. I guess the CI populates
2.2, 2.1, ...
directories of gh-pages frommain, jakarta, ...
branches?To validate that it works, I've tested it locally by switching to gh-pages branch and adding this fix in 2.1 and 2.2 directories. I've then served the files with a python http server:
See the video below; note the swagger URL version change in the inspection area.
Signed-off-by: Farshid Tavakolizadeh farshid.tavakolizadeh@canonical.com
PR Checklist
Please check if your PR fulfills the following requirements:
version-switcher-fix-2.1-2.2.mp4