Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stay on page after version switch (geneva) #684

Merged
merged 2 commits into from
Aug 10, 2022
Merged

fix: stay on page after version switch (geneva) #684

merged 2 commits into from
Aug 10, 2022

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Jan 28, 2022 •
edited
Loading

Same as #679 but for Geneva.

Related to #678

This fixes the version switch from version 1.2 to others, but not vice versa.

It also removes the obsolete versions, index, cname from this branch; see #680

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

@farshidtz
fix: stay on page after version switch
84314f4 
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
(cherry picked from commit 6653e8f)
@farshidtz farshidtz marked this pull request as draft February 1, 2022 10:40
@farshidtz
fix: remove redundant versions, index, cname files (edgexfoundry#680)
b69747c 
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz force-pushed the fix-version-switcher-geneva branch from 994cc60 to b69747c Compare February 2, 2022 10:02
@farshidtz farshidtz changed the base branch from main to geneva February 2, 2022 10:02
@farshidtz
Copy link
Member Author

The CI checks fails due to this unrelated deprecation warning:

Config value: 'google_analytics'. Warning: The configuration option google_analytics has been deprecated and will be removed in a future release of MkDocs. See the options available on your theme for an alternative.

We should either resolve that first or skip these fixes on geneva, depending on the decision made here: #683 (comment)

@farshidtz farshidtz marked this pull request as ready for review February 2, 2022 10:20
@lenny-goodell
Copy link
Member

We should either resolve that first or skip these fixes on geneva, depending on the decision made here: #683 (comment)

We should skip since this is an older 1.x release.

@farshidtz farshidtz closed this Feb 3, 2022
@farshidtz farshidtz mentioned this pull request Feb 15, 2022
Closed
@farshidtz farshidtz mentioned this pull request Jun 17, 2022
Merged
1 task
@farshidtz farshidtz reopened this Aug 10, 2022
@farshidtz
Copy link
Member Author

#820 has fixed the issue preventing the merging of this PR. We should be able to merge this now.

@farshidtz farshidtz requested a review from MonicaisHer August 10, 2022 08:49
MonicaisHer
MonicaisHer approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farshidtz Thank you for the changes. Looks good.

@farshidtz farshidtz merged commit 7583892 into edgexfoundry:geneva Aug 10, 2022
@farshidtz farshidtz deleted the fix-version-switcher-geneva branch August 10, 2022 08:58
edgex-jenkins added a commit that referenced this pull request Aug 10, 2022
@edgex-jenkins
ci: fix: stay on page after version switch (geneva) (#684)
f98f93a 
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaisHer MonicaisHer MonicaisHer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farshidtz @lenny-goodell @MonicaisHer