-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant version files in branches override the production versions #680
Comments
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
There are actually two version files. One on the top level, and another under /docs directory. Looks like the one under /docs overrides the top-level version file in gh-pages branch. Same goes for the |
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
The files are removed from ireland and jakarta branches, so future changes to those branches will not break the versioning. I could not fix this for hanoi and geneva because of unrelated CI failures, preventing this fix. Those branches are assumed frozen; see #684 (comment) and #683 (comment). To prevent this from happening without any CI solution in place, the following files should be removed from future branches created from main:
|
The CI overrides the
versions.json
file placed at gh-pages/versions.json with those sourced from any branch.The versions.json file on the main branch is considered as the ground truth. All others are obsolete and misleading. I suggest removing this file from release branches other than the main and modifying the CI to ignore them if kept by mistake.
The text was updated successfully, but these errors were encountered: