Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stay on page after version switch (hanoi) #683

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Jan 28, 2022

Same as #679 but for Hanoi.

Related to #678

This fixes the version switch from version 1.3 to others, but not vice versa.

It also removes the obsolete versions, index, cname from this branch; see #680

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
(cherry picked from commit 6653e8f)
@farshidtz farshidtz marked this pull request as draft February 1, 2022 10:40
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz force-pushed the fix-version-switcher-hanoi branch from 333fcee to cab77a0 Compare February 2, 2022 09:50
@farshidtz farshidtz marked this pull request as ready for review February 2, 2022 10:09
@farshidtz
Copy link
Member Author

@jpwhitemn @lenny-intel
The CI checks fails due to this unrelated deprecation warning:

Config value: 'google_analytics'. Warning: The configuration option google_analytics has been deprecated and will be removed in a future release of MkDocs. See the options available on your theme for an alternative.

Should we close without merging and skip these fixes for hanoi?

@lenny-goodell
Copy link
Member

Should we close without merging and skip these fixes for hanoi?

IMO, we should skip since Hanoi is a 1.x release.

@farshidtz
Copy link
Member Author

It's a pity that we can't get this and #684 merged. Google is indexing 1.2 first and users landing there won't easily find their way to the latest versions of pages.

@farshidtz farshidtz closed this Jun 17, 2022
@farshidtz farshidtz reopened this Aug 10, 2022
@farshidtz
Copy link
Member Author

farshidtz commented Aug 10, 2022

#819 has fixed the issue preventing the merging of this PR, but also overrode and broke the version master version file that this PR is trying to fix. We should be able to merge this now.

@farshidtz farshidtz requested a review from MonicaisHer August 10, 2022 08:49
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farshidtz Thank you for the changes.

@farshidtz farshidtz merged commit caf7318 into edgexfoundry:hanoi Aug 10, 2022
@farshidtz farshidtz deleted the fix-version-switcher-hanoi branch August 10, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants