-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stay on page after version switch (hanoi) #683
fix: stay on page after version switch (hanoi) #683
Conversation
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com> (cherry picked from commit 6653e8f)
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
333fcee
to
cab77a0
Compare
@jpwhitemn @lenny-intel
Should we close without merging and skip these fixes for hanoi? |
IMO, we should skip since Hanoi is a 1.x release. |
It's a pity that we can't get this and #684 merged. Google is indexing 1.2 first and users landing there won't easily find their way to the latest versions of pages. |
#819 has fixed the issue preventing the merging of this PR, but also overrode and broke the version master version file that this PR is trying to fix. We should be able to merge this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farshidtz Thank you for the changes.
Same as #679 but for Hanoi.
Related to #678
This fixes the version switch from version 1.3 to others, but not vice versa.
It also removes the obsolete versions, index, cname from this branch; see #680
PR Checklist
Please check if your PR fulfills the following requirements: