Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stay on page after version switch (ireland) #682

Merged

Conversation

farshidtz
Copy link
Member

Same as #679 but for Ireland.

Related to #678

This fixes the version switch from version 2.0 to others, but not vice versa.

It also removes the obsolete versions list from this branch; see #680

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
(cherry picked from commit 6653e8f)
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Copy link

@siggiskulason siggiskulason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siggiskulason siggiskulason merged commit fb2200c into edgexfoundry:ireland Jan 28, 2022
edgex-jenkins added a commit that referenced this pull request Jan 31, 2022
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
@farshidtz
Copy link
Member Author

The root files in gh-pages branch got overwritten again. It looks like the files under /docs are copied over; see #680 (comment)

Need to make another PR to get rid of those as well.

@farshidtz farshidtz deleted the fix-version-switcher-ireland branch February 23, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants