-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stay on page after version switch (jakarta) #681
fix: stay on page after version switch (jakarta) #681
Conversation
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
3fb4cf4
to
98ba574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
98ba574
to
ee73dee
Compare
I've updated my last commit to also remove the docs directory containing index.html, versions.json, and CNAME. These file override the main copies on gh-pages if they exist; see #680 (comment) I'm still not sure what is the purpose of the other versions.json file on the top level. This PR removes that as well. I've tested locally and the /docs seem to not affect local builds. @lenny-intel @ernestojeda please review and merge if you agree. Ideally without squashing for separation of concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @ernestojeda ?
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
@farshidtz , merged. Verified versions still intact. changing from Jakarta to Kamakura still resets, but I think something still needs time to reset for it to work. Please give it a try. |
Thanks @lenny-intel. Works for me. You need to clear your browser cache, to load the updated script. Or try incognito first. |
Yea, was thinking that was my issue. Verified using incognito . THX! |
Same as #679 but for Jakarta.
Related to #678
This fixes the version switch from version 2.1 to others, but not vice versa.
It also removes the obsolete versions list from this branch; see #680
PR Checklist
Please check if your PR fulfills the following requirements: