Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stay on page after version switch (jakarta) #681

Merged

Conversation

farshidtz
Copy link
Member

Same as #679 but for Jakarta.

Related to #678

This fixes the version switch from version 2.1 to others, but not vice versa.

It also removes the obsolete versions list from this branch; see #680

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz force-pushed the fix-version-switcher-jakarta branch from 3fb4cf4 to 98ba574 Compare January 28, 2022 16:36
Copy link

@siggiskulason siggiskulason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidtz farshidtz marked this pull request as draft February 1, 2022 10:49
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz force-pushed the fix-version-switcher-jakarta branch from 98ba574 to ee73dee Compare February 1, 2022 11:09
@farshidtz farshidtz marked this pull request as ready for review February 1, 2022 11:11
@farshidtz
Copy link
Member Author

I've updated my last commit to also remove the docs directory containing index.html, versions.json, and CNAME. These file override the main copies on gh-pages if they exist; see #680 (comment)

I'm still not sure what is the purpose of the other versions.json file on the top level. This PR removes that as well.

I've tested locally and the /docs seem to not affect local builds.

@lenny-intel @ernestojeda please review and merge if you agree. Ideally without squashing for separation of concern.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ernestojeda ?

@ernestojeda ernestojeda self-requested a review February 1, 2022 16:02
@lenny-goodell lenny-goodell merged commit ebc0fe0 into edgexfoundry:jakarta Feb 1, 2022
edgex-jenkins added a commit that referenced this pull request Feb 1, 2022
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
@lenny-goodell
Copy link
Member

please review and merge if you agree. Ideally without squashing for separation of concern.

@farshidtz , merged. Verified versions still intact. changing from Jakarta to Kamakura still resets, but I think something still needs time to reset for it to work. Please give it a try.

@farshidtz
Copy link
Member Author

Thanks @lenny-intel. Works for me. You need to clear your browser cache, to load the updated script. Or try incognito first.

@lenny-goodell
Copy link
Member

You need to clear your browser cache, to load the updated script. Or try incognito first.

Yea, was thinking that was my issue. Verified using incognito . THX!

@farshidtz farshidtz deleted the fix-version-switcher-jakarta branch February 2, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants