Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spoon error updating to Craft 3.1 #43

Closed
baileydoestech opened this issue Jan 16, 2019 · 7 comments
Closed

Spoon error updating to Craft 3.1 #43

baileydoestech opened this issue Jan 16, 2019 · 7 comments
Assignees
@joshangell
Labels
Bug Report Something isn't working

Comments

@baileydoestech
Copy link

Hi

We have isolated the error shown below, upgrading from Craft 3.0.37 to 3.1.0, to be caused by the Spoon plugin:

image

Is this something that could kindly be investigated?

Thanks

Luke
@baileydoestech
Copy link
Author

As a workaround, we can disable Spoon > Apply Craft 3.1 update > Re-enable Spoon

@joshangell joshangell self-assigned this Jan 16, 2019
@joshangell joshangell added the Bug Report Something isn't working label Jan 16, 2019
joshangell added a commit that referenced this issue Jan 16, 2019
@joshangell
Merge tag '3.2.5' into develop
cf9abb5 
- Fixed a bunch of issues when upgrading to Craft 3.1 ([#43](#43) & [#40](#40))
- Fixed a layout issue where the tabs would overlap with the disabled block icon ([#42](#42)).
- Stopped tracking node_modules ([#35](#35)).

* tag '3.2.5':
  Changelog for 3.2.5
@joshangell
Copy link
Contributor

Hey @lukebailey I think I’ve just fixed this ... give it an update and see :)

@phoob
Copy link
Contributor

phoob commented Jan 17, 2019

Hello! I had the same issue.. Now I installed 3.2.5, deactivated the plugin, updated Craft to 3.1.1, and reactivated the plugin. Then I got this error..

yii\base\ErrorException: Trying to get property 'handle' of non-object in /var/www/html/vendor/angellco/spoon/src/services/BlockTypes.php:404
Stack trace:
#0 /var/www/html/vendor/craftcms/cms/src/web/ErrorHandler.php(76): yii\base\ErrorHandler->handleError(8, 'Trying to get p...', '/var/www/html/v...', 404)
#1 /var/www/html/vendor/angellco/spoon/src/services/BlockTypes.php(404): craft\web\ErrorHandler->handleError(8, 'Trying to get p...', '/var/www/html/v...', 404, Array)
#2 /var/www/html/vendor/angellco/spoon/src/services/BlockTypes.php(145): angellco\spoon\services\BlockTypes->_populateBlockTypeFromRecord(Object(angellco\spoon\records\BlockType))
#3 /var/www/html/vendor/angellco/spoon/src/services/Loader.php(176): angellco\spoon\services\BlockTypes->getByContext('global', 'context')
#4 /var/www/html/vendor/angellco/spoon/src/services/Loader.php(144): angellco\spoon\services\Loader->fieldManipulator('global')
#5 /var/www/html/vendor/angellco/spoon/src/Spoon.php(93): angellco\spoon\services\Loader->run()
#6 [internal function]: angellco\spoon\Spoon->angellco\spoon\{closure}(Object(yii\base\Event))
#7 /var/www/html/vendor/yiisoft/yii2/base/Event.php(310): call_user_func(Object(Closure), Object(yii\base\Event))
#8 /var/www/html/vendor/yiisoft/yii2/base/Component.php(636): yii\base\Event::trigger('craft\\services\\...', 'afterLoadPlugin...', Object(yii\base\Event))
#9 /var/www/html/vendor/craftcms/cms/src/services/Plugins.php(268): yii\base\Component->trigger('afterLoadPlugin...')
#10 /var/www/html/vendor/craftcms/cms/src/services/Plugins.php(772): craft\services\Plugins->loadPlugins()
#11 /var/www/html/vendor/craftcms/cms/src/helpers/Component.php(66): craft\services\Plugins->isPluginEnabled('redactor')
#12 /var/www/html/vendor/craftcms/cms/src/services/Fields.php(546): craft\helpers\Component::createComponent(Array, 'craft\\base\\Fiel...')
#13 /var/www/html/vendor/craftcms/cms/src/services/Fields.php(571): craft\services\Fields->createField(Array)
#14 /var/www/html/vendor/craftcms/cms/src/elements/db/ElementQuery.php(1536): craft\services\Fields->getAllFields()
#15 /var/www/html/vendor/craftcms/cms/src/elements/db/ElementQuery.php(1073): craft\elements\db\ElementQuery->customFields()
#16 /var/www/html/vendor/yiisoft/yii2/db/QueryBuilder.php(227): craft\elements\db\ElementQuery->prepare(Object(craft\db\mysql\QueryBuilder))
#17 /var/www/html/vendor/yiisoft/yii2/db/Query.php(146): yii\db\QueryBuilder->build(Object(craft\elements\db\UserQuery))
#18 /var/www/html/vendor/yiisoft/yii2/db/Query.php(274): yii\db\Query->createCommand(Object(craft\db\Connection))
#19 /var/www/html/vendor/craftcms/cms/src/db/Query.php(177): yii\db\Query->one(NULL)
#20 /var/www/html/vendor/craftcms/cms/src/elements/db/ElementQuery.php(1215): craft\db\Query->one(NULL)
#21 /var/www/html/vendor/craftcms/cms/src/elements/User.php(367): craft\elements\db\ElementQuery->one()
#22 /var/www/html/vendor/yiisoft/yii2/web/User.php(690): craft\elements\User::findIdentity('914')
#23 /var/www/html/vendor/craftcms/cms/src/web/User.php(474): yii\web\User->renewAuthStatus()
#24 /var/www/html/vendor/yiisoft/yii2/web/User.php(192): craft\web\User->renewAuthStatus()
#25 /var/www/html/modules/elasticsearchmodule/src/ElasticsearchModule.php(140): yii\web\User->getIdentity()
#26 /var/www/html/vendor/yiisoft/yii2/base/BaseObject.php(109): modules\elasticsearchmodule\ElasticsearchModule->init()
#27 /var/www/html/vendor/yiisoft/yii2/base/Module.php(158): yii\base\BaseObject->__construct(Array)
#28 /var/www/html/modules/elasticsearchmodule/src/ElasticsearchModule.php(104): yii\base\Module->__construct('elasticsearch-m...', Object(craft\web\Application), Array)
#29 [internal function]: modules\elasticsearchmodule\ElasticsearchModule->__construct('elasticsearch-m...', Object(craft\web\Application), Array)
#30 /var/www/html/vendor/yiisoft/yii2/di/Container.php(383): ReflectionClass->newInstanceArgs(Array)
#31 /var/www/html/vendor/yiisoft/yii2/di/Container.php(156): yii\di\Container->build('modules\\elastic...', Array, Array)
#32 /var/www/html/vendor/yiisoft/yii2/BaseYii.php(349): yii\di\Container->get('modules\\elastic...', Array, Array)
#33 /var/www/html/vendor/yiisoft/yii2/base/Module.php(427): yii\BaseYii::createObject(Array, Array)
#34 /var/www/html/vendor/yiisoft/yii2/base/Application.php(315): yii\base\Module->getModule('elasticsearch-m...')
#35 /var/www/html/vendor/craftcms/cms/src/web/Application.php(128): yii\base\Application->bootstrap()
#36 /var/www/html/vendor/yiisoft/yii2/base/Application.php(273): craft\web\Application->bootstrap()
#37 /var/www/html/vendor/craftcms/cms/src/web/Application.php(110): yii\base\Application->init()
#38 /var/www/html/vendor/yiisoft/yii2/base/BaseObject.php(109): craft\web\Application->init()
#39 /var/www/html/vendor/yiisoft/yii2/base/Application.php(206): yii\base\BaseObject->__construct(Array)
#40 /var/www/html/vendor/craftcms/cms/src/web/Application.php(100): yii\base\Application->__construct(Array)
#41 [internal function]: craft\web\Application->__construct(Array)
#42 /var/www/html/vendor/yiisoft/yii2/di/Container.php(383): ReflectionClass->newInstanceArgs(Array)
#43 /var/www/html/vendor/yiisoft/yii2/di/Container.php(156): yii\di\Container->build('craft\\web\\Appli...', Array, Array)
#44 /var/www/html/vendor/yiisoft/yii2/BaseYii.php(349): yii\di\Container->get('craft\\web\\Appli...', Array, Array)
#45 /var/www/html/vendor/craftcms/cms/bootstrap/bootstrap.php(255): yii\BaseYii::createObject(Array)
#46 /var/www/html/vendor/craftcms/cms/bootstrap/web.php(42): require('/var/www/html/v...')
#47 /var/www/html/web/index.php(35): require('/var/www/html/v...')
#48 {main}

@joshangell
Copy link
Contributor

joshangell commented Jan 17, 2019 via email

@joshangell joshangell reopened this Jan 18, 2019
joshangell added a commit that referenced this issue Jan 18, 2019
@joshangell
If for some reason we can’t get the matrix field by ID then return null.
52a5f6f 
See #43
@joshangell joshangell reopened this Jan 18, 2019
joshangell added a commit that referenced this issue Jan 21, 2019
@joshangell
Merge tag '3.2.6' into develop
3acc113 
- Fixed another issue when upgrading to Craft 3.1 ([#43](#43))

* tag '3.2.6':
  Changelog for 3.2.6
@joshangell
Copy link
Contributor

Hi @phoob you can give it another whirl now, just pushed a release that should fix this ...

@phoob
Copy link
Contributor

phoob commented Feb 11, 2019

Hi @phoob you can give it another whirl now, just pushed a release that should fix this ...

Hi @joshangell ! I still had this problem. Made it vanish by refreshing field cache before using fields->getFieldsById(...). See pull request!

phoob added a commit to phoob/Spoon that referenced this issue Feb 11, 2019
@phoob
Update BlockTypes.php
09434d9 
See doublesecretagency#43 (comment)
@phoob phoob mentioned this issue Feb 11, 2019
Merged
@joshangell
Copy link
Contributor

@phoob ah brilliant, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshangell joshangell

Labels
Bug Report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshangell @phoob @baileydoestech