Remove rules from Settings model #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plugins/modules rely on reading out the Settings rules. Having the string 'array' as a placeholder causes problems.
|
Hi @dkorrel, thanks for making this PR. I can’t actually reproduce any problems with the Schematic plugin and Spoon, but I did notice the rules weren’t actually declared properly. I have fixed this now in 9823ce6 - could you check at your end if this fixes your issues? If not, could you provide more detail to help me reproduce it? |
|
Closing due to inactivity. |
joshangell
added a commit
that referenced
this pull request
Sep 13, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins/modules rely on reading out the Settings rules. Having the string 'array' as a placeholder causes problems. For example with the Schematic plugin https://github.com/nerds-and-company/schematic