Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageOptimize plugin field settings do not display when Spoon is enabled #15

Closed
BenParizek opened this issue Aug 10, 2018 · 5 comments
Closed
Assignees
Labels
Bug Report Something isn't working

Comments

@BenParizek
Copy link

BenParizek commented Aug 10, 2018

Screenshot: http://share.barrelstrength.co/10390c1z1N2D
Related issue: nystudio107/craft-imageoptimize#94

The ImageOptimize plugin uses matrix block classes in how it styles its settings pages:
https://github.com/nystudio107/craft-imageoptimize/blob/v1/src/templates/_components/fields/OptimizedImages_settings.twig#L69

It seems the styles Spoon adds to the CP may conflict with these in some way. I haven't dug too deep so not sure if the primary issue is in Spoon or in ImageOptimize. Hopefully you folks can coordinate and find a common ground.

@joshangell
Copy link
Contributor

joshangell commented Aug 10, 2018 via email

@joshangell joshangell self-assigned this Aug 10, 2018
@joshangell joshangell added the Bug Report Something isn't working label Aug 10, 2018
@joshangell
Copy link
Contributor

joshangell commented Aug 10, 2018 via email

@khalwat
Copy link

khalwat commented Aug 11, 2018

Yep, I'm happy to add whatever wrapper class you need me to add @joshangell -- just lmk where/how to add it!

@joshangell
Copy link
Contributor

@BenParizek Fixed in this PR here: nystudio107/craft-imageoptimize#96

@joshangell
Copy link
Contributor

Fixed in the confetti release: https://github.com/nystudio107/craft-imageoptimize/releases/tag/1.4.38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants