-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageOptimize plugin field settings do not display when Spoon is enabled #15
Labels
Bug Report
Something isn't working
Comments
Thanks Ben, I'll take a look!
…On Fri, 10 Aug 2018, 04:50 Ben Parizek, ***@***.***> wrote:
Screenshot:
http://share.barrelstrength.co/10390c1z1N2D
The ImageOptimize plugin uses matrix block classes in how it styles it's
settings pages:
https://github.com/nystudio107/craft-imageoptimize/blob/v1/src/templates/_components/fields/OptimizedImages_settings.twig#L69
It seems the styles Spoon adds to the CP may conflict with these in some
way. I haven't dug to deep so not sure if the primary issue is in Spoon or
in ImageOptimize.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYq--v7aR00t3E8O_4I84JKKL-5PZliks5uPQMJgaJpZM4V3jC4>
.
|
This is fixable, when I’m next at my computer I’ll work out the class to exclude but it’s the same solution as we did for Super Table here: angell-co/Pimp-My-Matrix#32
|
Yep, I'm happy to add whatever wrapper class you need me to add @joshangell -- just lmk where/how to add it! |
@BenParizek Fixed in this PR here: nystudio107/craft-imageoptimize#96 |
Fixed in the confetti release: https://github.com/nystudio107/craft-imageoptimize/releases/tag/1.4.38 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Screenshot: http://share.barrelstrength.co/10390c1z1N2D
Related issue: nystudio107/craft-imageoptimize#94
The ImageOptimize plugin uses matrix block classes in how it styles its settings pages:
https://github.com/nystudio107/craft-imageoptimize/blob/v1/src/templates/_components/fields/OptimizedImages_settings.twig#L69
It seems the styles Spoon adds to the CP may conflict with these in some way. I haven't dug too deep so not sure if the primary issue is in Spoon or in ImageOptimize. Hopefully you folks can coordinate and find a common ground.
The text was updated successfully, but these errors were encountered: