Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spoon plugin causes ImageOptimize field settings to disappear #94

Closed
BenParizek opened this issue Aug 10, 2018 · 1 comment
Closed

Spoon plugin causes ImageOptimize field settings to disappear #94

BenParizek opened this issue Aug 10, 2018 · 1 comment

Comments

@BenParizek
Copy link

Screenshot: http://share.barrelstrength.co/10390c1z1N2D
Related Issue: doublesecretagency/craft-spoon#15

The ImageOptimize plugin uses matrix block classes in how it styles its settings pages:
https://github.com/nystudio107/craft-imageoptimize/blob/v1/src/templates/_components/fields/OptimizedImages_settings.twig#L69

It seems the styles Spoon adds to the CP may conflict with these in some way. I haven't dug too deep so not sure if the primary issue is in Spoon or in ImageOptimize. Hopefully you folks can coordinate and find a common ground.
@BenParizek BenParizek mentioned this issue Aug 10, 2018
Closed
@khalwat
Copy link
Contributor

khalwat commented Aug 10, 2018

I'm gonna blame Josh for this. I'm just re-using existing CSS styles ¯_(ツ)_/¯

@khalwat khalwat closed this as completed Aug 10, 2018
@joshangell joshangell mentioned this issue Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenParizek @khalwat