This repository has been archived by the owner on Jul 10, 2018. It is now read-only.
Fixed issue with invisible fields in element modals #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix fields aren’t getting “pimped” in element modals, but their fields were still getting hidden. Made a change to show fields if they’re within one of these modal windows.
|
Also fixed the same issue with matrix fields inside Super Table fields. |
|
This is really helpful, thanks! I'll take a look soon and merge it. |
|
This will be merged in the next release, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrix fields aren’t getting “pimped” in element modals, but their fields were still getting hidden. Made a change to show fields if they’re within one of these modal windows.
Not sure if you're taking pull requests but thought I'd open one anyway!