Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined label in preview mode #5

Closed
kisonay opened this issue Jul 6, 2018 · 11 comments
Closed

undefined label in preview mode #5

kisonay opened this issue Jul 6, 2018 · 11 comments
Assignees
@joshangell
Labels
Bug Report Something isn't working

Comments

@kisonay
Copy link

kisonay commented Jul 6, 2018

When in live preview mode, the matrix dropdown is being displayed as "undefined"
screen shot 2018-07-05 at 8 22 16 pm
@joshangell
Copy link
Contributor

Hi @kisonay, I’m not sure how you are seeing this ... are you on the latest dev-develop tag?

@kisonay
Copy link
Author

kisonay commented Jul 6, 2018

actually useing dev-master let me try dev-develop

@kisonay
Copy link
Author

kisonay commented Jul 6, 2018

Yes, i still see this in dev-develop what can I do to provide more info?

@joshangell
Copy link
Contributor

joshangell commented Jul 6, 2018 •
edited
Loading

Could you paste a larger screenshot and include the whole window? And the Craft version you are on.

@kisonay
Copy link
Author

kisonay commented Jul 6, 2018

Craft edition & version | Craft Pro 3.0.14

Looks to be specifically related to the width of the live preview editor column.

screen shot 2018-07-06 at 9 34 45 am

Narrower column:

screen shot 2018-07-06 at 9 34 56 am

Can I also recomend a better UI for tabs in this mode? They bunch all up and you can't read them. Can we have a dropdown simliar to the gear icon and just show the currently active tab?

screen shot 2018-07-06 at 9 35 19 am

screen shot 2018-07-06 at 9 38 45 am

@joshangell
Copy link
Contributor

Aaah got it, and yep - I noticed the tabs issue yesterday, will log it :)

@joshangell joshangell self-assigned this Jul 6, 2018
@joshangell joshangell added the Bug Report Something isn't working label Jul 6, 2018
joshangell added a commit that referenced this issue Jul 6, 2018
@joshangell
Fixed a missing translation group key.
a68fd82 
Fixes #5
@joshangell
Copy link
Contributor

OK, you can see the fixed version now in the tag dev-release/3.0.0

@kisonay
Copy link
Author

kisonay commented Jul 6, 2018

requirement of Craft 3.0.15 which doesnt seem to be availble yet.

@joshangell
Copy link
Contributor

Ah, sorry, thats because I’m waiting for a change in the core to be released ... I’ve temporarily disabled that now ...

@kisonay
Copy link
Author

kisonay commented Jul 6, 2018

Add block label has been fixed (no longer shows as undefined.) Do you want me to open a seporate issue for the field tabs?

@joshangell
Copy link
Contributor

Thanks for confirming that - I have already opened a new issue for the tabs here: #6

Thanks for your help!

joshangell added a commit that referenced this issue Jul 10, 2018
@joshangell
Merge tag '3.0.0' into develop
ddec0c4 
- Added the `nestedSettings` config setting to allow a new, nested settings menu format ([#2](#2))
- Added the Craft 2 > 3 migration

- Fixed an issue where switching the entry type didn’t update the UI - requires Craft v3.0.15 or greater ([#4](#4))
- Fixed a missing translation group key ([#5](#5))

* tag '3.0.0':
  Changelog for 3.0.0
  Readme tweaks
  Require version 3.0.15 of Craft for the entry type switcher
  Temporarily downgrade the required craft cms version
  Fixed a missing translation group key.
  Prep for release, pending craftcms/cms:3.0.15 or similar.
@ricdev ricdev mentioned this issue Sep 13, 2018
Closed
@joshangell joshangell mentioned this issue Jan 17, 2019
Closed
@heymarkreeves heymarkreeves mentioned this issue Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshangell joshangell

Labels
Bug Report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshangell @kisonay