Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel context menu should have option to reopen from its stack #1931

Closed
wusteven815 opened this issue Apr 12, 2024 · 0 comments · Fixed by #1932 or deephaven/deephaven-core#5439
Closed
Assignees
Labels
enhancement New feature or request

Comments

@wusteven815
Copy link
Contributor

Continuation of #1912 (comment). The context menu of panels should have an option to reopen the last closed panel from that stack only.

@wusteven815 wusteven815 added enhancement New feature or request triage Issue requires triage labels Apr 12, 2024
@wusteven815 wusteven815 self-assigned this Apr 12, 2024
@wusteven815 wusteven815 removed the triage Issue requires triage label Apr 12, 2024
@wusteven815 wusteven815 linked a pull request Apr 12, 2024 that will close this issue
wusteven815 added a commit that referenced this issue Apr 26, 2024
- Adds #1931 
  - Add new context menu option for panels
  - Give IDs to stacks and helper function to get stacks by ID
  - Add ability to open component to specific stack
  - Fix unit tests related to IDs and layouts, added E2E tests

---------

Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue May 1, 2024
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.75.0

# [0.75.0](deephaven/web-client-ui@v0.74.0...v0.75.0) (2024-05-01)


### Bug Fixes

* change fira source ([#1944](deephaven/web-client-ui#1944)) ([07e5a26](deephaven/web-client-ui@07e5a26)), closes [#1902](deephaven/web-client-ui#1902)
* Fix null partition filter ([#1954](deephaven/web-client-ui#1954)) ([3a1f92b](deephaven/web-client-ui@3a1f92b)), closes [#1867](deephaven/web-client-ui#1867)


### Features

* context menu reopen for stack only ([#1932](deephaven/web-client-ui#1932)) ([6a9a6a4](deephaven/web-client-ui@6a9a6a4)), closes [#1931](deephaven/web-client-ui#1931)
* Create an ErrorView that can be used to display errors ([#1965](deephaven/web-client-ui#1965)) ([65ef1a7](deephaven/web-client-ui@65ef1a7))
* ListView + Picker - Item icon support ([#1959](deephaven/web-client-ui#1959)) ([cb13c60](deephaven/web-client-ui@cb13c60)), closes [#1890](deephaven/web-client-ui#1890)
* Picker - initial scroll position ([#1942](deephaven/web-client-ui#1942)) ([5f49761](deephaven/web-client-ui@5f49761)), closes [#1890](deephaven/web-client-ui#1890) [#1935](deephaven/web-client-ui#1935)

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
stanbrub pushed a commit to deephaven/deephaven-core that referenced this issue May 3, 2024
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.75.0

# [0.75.0](deephaven/web-client-ui@v0.74.0...v0.75.0) (2024-05-01)


### Bug Fixes

* change fira source ([#1944](deephaven/web-client-ui#1944)) ([07e5a26](deephaven/web-client-ui@07e5a26)), closes [#1902](deephaven/web-client-ui#1902)
* Fix null partition filter ([#1954](deephaven/web-client-ui#1954)) ([3a1f92b](deephaven/web-client-ui@3a1f92b)), closes [#1867](deephaven/web-client-ui#1867)


### Features

* context menu reopen for stack only ([#1932](deephaven/web-client-ui#1932)) ([6a9a6a4](deephaven/web-client-ui@6a9a6a4)), closes [#1931](deephaven/web-client-ui#1931)
* Create an ErrorView that can be used to display errors ([#1965](deephaven/web-client-ui#1965)) ([65ef1a7](deephaven/web-client-ui@65ef1a7))
* ListView + Picker - Item icon support ([#1959](deephaven/web-client-ui#1959)) ([cb13c60](deephaven/web-client-ui@cb13c60)), closes [#1890](deephaven/web-client-ui#1890)
* Picker - initial scroll position ([#1942](deephaven/web-client-ui#1942)) ([5f49761](deephaven/web-client-ui@5f49761)), closes [#1890](deephaven/web-client-ui#1890) [#1935](deephaven/web-client-ui#1935)

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant