-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change fira source #1944
fix: change fira source #1944
Conversation
@dsmmcken would these differences be expected/okay? Fonts appear okay to me, tabular numbering etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Fira Mono
, which is being substituted. The previous package included both Fira Sans and Mono, you'll have to add those in as well.
That's frustrating that the kerning tables must be different. Still looks acceptable, and has correct font-features-settings. 🤷
7c5f57e
to
9308555
Compare
75584a0
to
d3093d4
Compare
e0ec445
to
c6f04fb
Compare
Co-authored-by: Don <dsmmcken@gmail.com>
Co-authored-by: Don <dsmmcken@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to re-run npm install
to update the package-lock.json
now.
@fontsource
instead of GitHub as source