fix: change fira source #1944
Merged
fix: change fira source #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsmmcken would these differences be expected/okay? Fonts appear okay to me, tabular numbering etc. Actual: Expected: Diff: From in the app on a table with numbers: |
dsmmcken
previously requested changes
Apr 18, 2024
There was a problem hiding this comment.
Missing Fira Mono, which is being substituted. The previous package included both Fira Sans and Mono, you'll have to add those in as well.
That's frustrating that the kerning tables must be different. Still looks acceptable, and has correct font-features-settings. 🤷
|
We are probably also missing an italic version in that weight. |
wusteven815
force-pushed
the
change-fira-source
branch
from
7c5f57e
to
9308555
Compare
wusteven815
force-pushed
the
change-fira-source
branch
from
75584a0
to
d3093d4
Compare
dsmmcken
reviewed
Apr 24, 2024
wusteven815
force-pushed
the
change-fira-source
branch
from
e0ec445
to
c6f04fb
Compare
Co-authored-by: Don <dsmmcken@gmail.com>
Co-authored-by: Don <dsmmcken@gmail.com>
dsmmcken
previously approved these changes
Apr 25, 2024
mofojed
previously approved these changes
Apr 26, 2024
mofojed
previously requested changes
Apr 26, 2024
mofojed
approved these changes
Apr 26, 2024
dsmmcken
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fontsourceinstead of GitHub as source