-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fira fonts require GitHub to install #1902
Fira fonts require GitHub to install #1902
Comments
I forget the reason we did this, but there was one. |
In enterprise we use to embed them in the repo directly. I think we switched to a package to get license provenance. (non-accessible commit switching it in core repo before it became deephaven-core, while it was still being split) At the time there was no versions of it on npm. I looked at @fontsource/fira-sans and that would probably be fine. I can confirm it is correctly publishing the font with feature settings for tabular numbers preserved. |
- Adds #1902 - Use `@fontsource` instead of GitHub as source - Lock to Fira Sans to 5.0.20 and Fira Mono to 5.0.13 to prevent kerning problems --------- Co-authored-by: Don <dsmmcken@gmail.com>
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.75.0 # [0.75.0](deephaven/web-client-ui@v0.74.0...v0.75.0) (2024-05-01) ### Bug Fixes * change fira source ([#1944](deephaven/web-client-ui#1944)) ([07e5a26](deephaven/web-client-ui@07e5a26)), closes [#1902](deephaven/web-client-ui#1902) * Fix null partition filter ([#1954](deephaven/web-client-ui#1954)) ([3a1f92b](deephaven/web-client-ui@3a1f92b)), closes [#1867](deephaven/web-client-ui#1867) ### Features * context menu reopen for stack only ([#1932](deephaven/web-client-ui#1932)) ([6a9a6a4](deephaven/web-client-ui@6a9a6a4)), closes [#1931](deephaven/web-client-ui#1931) * Create an ErrorView that can be used to display errors ([#1965](deephaven/web-client-ui#1965)) ([65ef1a7](deephaven/web-client-ui@65ef1a7)) * ListView + Picker - Item icon support ([#1959](deephaven/web-client-ui#1959)) ([cb13c60](deephaven/web-client-ui@cb13c60)), closes [#1890](deephaven/web-client-ui#1890) * Picker - initial scroll position ([#1942](deephaven/web-client-ui#1942)) ([5f49761](deephaven/web-client-ui@5f49761)), closes [#1890](deephaven/web-client-ui#1890) [#1935](deephaven/web-client-ui#1935) Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.75.0 # [0.75.0](deephaven/web-client-ui@v0.74.0...v0.75.0) (2024-05-01) ### Bug Fixes * change fira source ([#1944](deephaven/web-client-ui#1944)) ([07e5a26](deephaven/web-client-ui@07e5a26)), closes [#1902](deephaven/web-client-ui#1902) * Fix null partition filter ([#1954](deephaven/web-client-ui#1954)) ([3a1f92b](deephaven/web-client-ui@3a1f92b)), closes [#1867](deephaven/web-client-ui#1867) ### Features * context menu reopen for stack only ([#1932](deephaven/web-client-ui#1932)) ([6a9a6a4](deephaven/web-client-ui@6a9a6a4)), closes [#1931](deephaven/web-client-ui#1931) * Create an ErrorView that can be used to display errors ([#1965](deephaven/web-client-ui#1965)) ([65ef1a7](deephaven/web-client-ui@65ef1a7)) * ListView + Picker - Item icon support ([#1959](deephaven/web-client-ui#1959)) ([cb13c60](deephaven/web-client-ui@cb13c60)), closes [#1890](deephaven/web-client-ui#1890) * Picker - initial scroll position ([#1942](deephaven/web-client-ui#1942)) ([5f49761](deephaven/web-client-ui@5f49761)), closes [#1890](deephaven/web-client-ui#1890) [#1935](deephaven/web-client-ui#1935) Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
All of our dependencies are stored in the npmjs registry, except for fira, which references the GitHub URL directly:
web-client-ui/packages/app-utils/package.json
Line 51 in b49b506
That could be a problem when installing the package, as a) They may have access to pulling from GitHub blocked/locked down, and/or b) That repository is not guaranteed to always exist; the packages published on npmjs should always be there.
The text was updated successfully, but these errors were encountered: