-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DH-16595: Fix null partition filter #1954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor display string change, can you also include how this was tested in the PR description?
Changed |
I tested this in a Core+ worker and it looks like the api returns |
Partitioned table with a DHC shows an extra empty |
Added nullish coalescing to account for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion to include the core ticket number.
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Closes #1867
Tested in Enterprise using steps from DH-16595 - created a partitioned table and set ACL to
nullFilterGenerator()
to get thenull
value in the partition column. Creating a partitioned table with anull
in the partition column doesn't seem possible withdb.addTablePartition
in Enterprise.Core+ Groovy console: