feat: Create an ErrorView that can be used to display errors #1965
Conversation
mofojed
commented
Apr 25, 2024
mofojed
commented
- Added to the StyleGuide as well
- Displays errors in a textarea, with a copy button and an expand button
- Added to the StyleGuide as well - Displays errors in a textarea, with a copy button and an expand button
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
=======================================
Coverage ? 46.28%
=======================================
Files ? 663
Lines ? 38612
Branches ? 9780
=======================================
Hits ? 17871
Misses ? 20688
Partials ? 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Make it so the title of the error will truncate if necessary - Expand button only shows if the error doesn't fit in the small view
- Makes it grow more than necessary when expanded
- Needed to update snapshots after merging the latest - Fonts were a little bit different
| color: $black; | ||
| opacity: 0.8; | ||
| padding: $spacer-1; | ||
| &:active { | ||
| color: $black; |
There was a problem hiding this comment.
| color: $black; | |
| opacity: 0.8; | |
| padding: $spacer-1; | |
| &:active { | |
| color: $black; | |
| color: var(--dh-color-contrast-dark); | |
| opacity: 0.8; | |
| padding: $spacer-1; | |
| &:active { | |
| color: var(--dh-color-contrast-dark); |
Got to watch those color variables for light theme.
There was a problem hiding this comment.
We could try adding a stylelint rule to ban sass variables basically. I think we could use this rule and set the regex to something like /iWillNotUseSassVariables/ which would effectively ban sass variables I think
There was a problem hiding this comment.
Would need rules to allow for $spacer as well.
