Clean up based on review

deephaven · Apr 30, 2024 · a050800 · a050800
1 parent 8f56be9
commit a050800
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/components/src/ErrorView.scss b/packages/components/src/ErrorView.scss
@@ -53,11 +53,11 @@
 
       .btn-danger {
         border-radius: 0;
-        color: $black;
+        color: var(--dh-color-contrast-dark);
         opacity: 0.8;
         padding: $spacer-1;
         &:active {
-          color: $black;
+          color: var(--dh-color-contrast-dark);
         }
       }
 

diff --git a/packages/components/src/ErrorView.tsx b/packages/components/src/ErrorView.tsx
@@ -35,13 +35,13 @@ function ErrorView({
   const textRef = useRef<HTMLPreElement>(null);
 
   const handleResize = useCallback(() => {
-    if (isExpanded || textRef.current == null) {
+    if (isExpanded || isExpandedProp || textRef.current == null) {
       return;
     }
     const newIsExpandable =
       textRef.current.scrollHeight > textRef.current.clientHeight;
     setIsExpandable(newIsExpandable);
-  }, [isExpanded]);
+  }, [isExpanded, isExpandedProp]);
 
   const debouncedHandleResize = useDebouncedCallback(handleResize, 100);