Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming - Spectrum DH Theme #1543

Closed
bmingles opened this issue Sep 25, 2023 · 0 comments · Fixed by #1582 or deephaven/deephaven-core#4712
Closed

Theming - Spectrum DH Theme #1543

bmingles opened this issue Sep 25, 2023 · 0 comments · Fixed by #1582 or deephaven/deephaven-core#4712
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui

Comments

@bmingles
Copy link
Contributor

bmingles commented Sep 25, 2023 •
edited
Loading

Create custom Spectrum theme variables mapped to DH theme variables (defined in #1538). Custom Spectrum theme provider component to provide this theme.

Epic: #1537
@bmingles bmingles added enhancement New feature or request web-client-ui labels Sep 25, 2023
@bmingles bmingles mentioned this issue Sep 25, 2023
Closed
13 tasks
@bmingles bmingles self-assigned this Sep 25, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 17, 2023
@bmingles
Spectrum theme provider
1ed7fbb 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 17, 2023
@bmingles
Spectrum theme + styleguide
950c42d 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 17, 2023
@bmingles
Removed unused code
0907fa6 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 17, 2023
@bmingles
Spectrum samples
e7e516e 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 17, 2023
@bmingles
Spectrum samples
96acf76 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Added a menu for styleguide
97c78e7 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Spectrum theme provider
968ff4b 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Spectrum theme + styleguide
9656c02 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Removed unused code
94c230e 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Spectrum samples
a371805 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Spectrum samples
4b98fb6 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Added a menu for styleguide
676fbe1 
deephaven#1543
@bmingles bmingles mentioned this issue Oct 18, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 18, 2023
@bmingles
Updated comments and added transition
f38f379 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 19, 2023
@bmingles
Theme overrides + deleted unused modules
90f050f 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 19, 2023
@bmingles
Updated snapshots
85c71c1 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 19, 2023
@bmingles
Fixed failing tests
16faf05 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 19, 2023
@bmingles
Fixed failing test
8b19a33 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 19, 2023
@bmingles
Playwright fixes
9a730c8 
- Pinning to 1.37.1
- Firefox pointer fixes

deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 19, 2023
@bmingles
Fixed snapshots after Firefox pointer fix
7cb691f 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Added mocks for theme files
ba94735 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Spectrum theme provider
d74b335 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Spectrum theme + styleguide
0a699dc 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Removed unused code
876ef5d 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Spectrum samples
62f517f 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Spectrum samples
730dbe5 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Added a menu for styleguide
095209e 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Updated comments and added transition
9085317 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Theme overrides + deleted unused modules
9147e5a 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Updated snapshots
e773f30 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Fixed failing tests
5953e2c 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Fixed failing test
9779f4d 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Added mocks for theme files
8537f41 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 23, 2023
@bmingles
Moved themes outside of Spectrum provider
f3bdbf4 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 23, 2023
@bmingles
Only set preload data after themes loaded
c0b9c2b 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 23, 2023
@bmingles
ThemProvider now always passes children
b4be075 
deephaven#1543
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 23, 2023
@bmingles
Updated comment
870156b 
deephaven#1543
bmingles added a commit that referenced this issue Oct 24, 2023
@bmingles
feat: Theming - Spectrum Provider (#1582)
a4013c0 
In this PR:
- First pass of mapping Spectrum dark theme variables to DH theme
variables
- Added Spectrum components that are being used by DH UI to the
styleguide
- Added some navigation to styleguide
- Added a Playwright config for Firefox to fix an issue where no
pointers were detected in `'(any-pointer: fine)'` media queries

resolves #1543
@mofojed mofojed mentioned this issue Oct 24, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Oct 25, 2023
@github-actions @deephaven-internal
Update web version 0.51.0 (#4712)
8e63c05 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.51.0

# [0.51.0](deephaven/web-client-ui@v0.50.0...v0.51.0) (2023-10-24)


### Bug Fixes

* Adjusted Monaco "white" colors ([#1594](deephaven/web-client-ui#1594)) ([c736708](deephaven/web-client-ui@c736708)), closes [#1592](deephaven/web-client-ui#1592)
* cap width of columns with long names ([#1574](deephaven/web-client-ui#1574)) ([876a6ac](deephaven/web-client-ui@876a6ac)), closes [#1276](deephaven/web-client-ui#1276)
* Enabled pointer capabilities for Firefox in Playwright ([#1589](deephaven/web-client-ui#1589)) ([f440a38](deephaven/web-client-ui@f440a38)), closes [#1588](deephaven/web-client-ui#1588)
* Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list ([#1596](deephaven/web-client-ui#1596)) ([7b59763](deephaven/web-client-ui@7b59763)), closes [#1593](deephaven/web-client-ui#1593)
* Tab in console input triggers autocomplete instead of indent ([#1591](deephaven/web-client-ui#1591)) ([fbe1e70](deephaven/web-client-ui@fbe1e70))


### Features

* Theming - Spectrum Provider ([#1582](deephaven/web-client-ui#1582)) ([a4013c0](deephaven/web-client-ui@a4013c0)), closes [#1543](deephaven/web-client-ui#1543)
* Theming Iris Grid ([#1568](deephaven/web-client-ui#1568)) ([ed8f4b7](deephaven/web-client-ui@ed8f4b7))
* web-client-ui changes required for deephaven.ui ([#1567](deephaven/web-client-ui#1567)) ([94ab25c](deephaven/web-client-ui@94ab25c))
* Widget plugins ([#1564](deephaven/web-client-ui#1564)) ([94cc82c](deephaven/web-client-ui@94cc82c)), closes [#1455](deephaven/web-client-ui#1455) [#1167](deephaven/web-client-ui#1167)


### BREAKING CHANGES

- `usePlugins` and `PluginsContext` were moved from
`@deephaven/app-utils` to `@deephaven/plugin`.
- `useLoadTablePlugin` was moved from `@deephaven/app-utils` to
`@deephaven/dashboard-core-plugins`.
- `useConnection` and `ConnectionContext` were moved from
`@deephaven/app-utils` to `@deephaven/jsapi-components`.
- `DeephavenPluginModuleMap` was removed from `@deephaven/redux`. Use
`PluginModuleMap` from `@deephaven/plugin` instead.
* Enterprise will need ThemeProvider for the css
variables to be available





Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
1 participant
@bmingles