Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better error message to user when table API request's result_id is missing #1167

Closed
nbauernfeind opened this issue Aug 31, 2021 · 0 comments · Fixed by #1174
Closed
Assignees
Labels
bug Something isn't working grpc
Milestone

Comments

@nbauernfeind
Copy link
Member

Currently if the user forgets to set a result ticket for a one-shot table rpc, they get an awfully obscure error:

grpc-api_1    | 2021-08-31T02:02:55.007Z | c-nio-worker-ELG-3-2 | ERROR | .g.t.TableServiceGrpcImpl | io.grpc.StatusRuntimeException: FAILED_PRECONDITION: Cannot parse ticket: found 0x (hex)
grpc-api_1    |         at io.grpc.Status.asRuntimeException(Status.java:535)
grpc-api_1    |         at io.grpc.protobuf.StatusProto.toStatusRuntimeException(StatusProto.java:52)
grpc-api_1    |         at io.deephaven.grpc_api.util.Exceptions.statusRuntimeException(Exceptions.java:15)
grpc-api_1    |         at io.deephaven.grpc_api.util.ExportTicketHelper.ticketToExportIdInternal(ExportTicketHelper.java:267)
grpc-api_1    |         at io.deephaven.grpc_api.util.ExportTicketHelper.ticketToExportId(ExportTicketHelper.java:66)
grpc-api_1    |         at io.deephaven.grpc_api.session.SessionState.newExport(SessionState.java:330)
grpc-api_1    |         at io.deephaven.grpc_api.table.TableServiceGrpcImpl.lambda$oneShotOperationWrapper$15(TableServiceGrpcImpl.java:406)
grpc-api_1    |         at io.deephaven.grpc_api.util.GrpcUtil.rpcWrapper(GrpcUtil.java:33)
grpc-api_1    |         at io.deephaven.grpc_api.table.TableServiceGrpcImpl.oneShotOperationWrapper(TableServiceGrpcImpl.java:393)
grpc-api_1    |         at io.deephaven.grpc_api.table.TableServiceGrpcImpl.fetchTable(TableServiceGrpcImpl.java:252)
[ ... ]

The batch operation allows the user to do this on purpose, so that they may create what Devin calls "tainted" nodes in the DAG that cannot guaranteed to be recovered. This should just be a better error message "hey, I can do this, but don't you want me to write it some place?".

@nbauernfeind nbauernfeind added bug Something isn't working grpc labels Aug 31, 2021
@nbauernfeind nbauernfeind added this to the Aug 2021 milestone Aug 31, 2021
@nbauernfeind nbauernfeind self-assigned this Aug 31, 2021
mofojed pushed a commit that referenced this issue Oct 25, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.51.0

# [0.51.0](deephaven/web-client-ui@v0.50.0...v0.51.0) (2023-10-24)


### Bug Fixes

* Adjusted Monaco "white" colors ([#1594](deephaven/web-client-ui#1594)) ([c736708](deephaven/web-client-ui@c736708)), closes [#1592](deephaven/web-client-ui#1592)
* cap width of columns with long names ([#1574](deephaven/web-client-ui#1574)) ([876a6ac](deephaven/web-client-ui@876a6ac)), closes [#1276](deephaven/web-client-ui#1276)
* Enabled pointer capabilities for Firefox in Playwright ([#1589](deephaven/web-client-ui#1589)) ([f440a38](deephaven/web-client-ui@f440a38)), closes [#1588](deephaven/web-client-ui#1588)
* Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list ([#1596](deephaven/web-client-ui#1596)) ([7b59763](deephaven/web-client-ui@7b59763)), closes [#1593](deephaven/web-client-ui#1593)
* Tab in console input triggers autocomplete instead of indent ([#1591](deephaven/web-client-ui#1591)) ([fbe1e70](deephaven/web-client-ui@fbe1e70))


### Features

* Theming - Spectrum Provider ([#1582](deephaven/web-client-ui#1582)) ([a4013c0](deephaven/web-client-ui@a4013c0)), closes [#1543](deephaven/web-client-ui#1543)
* Theming Iris Grid ([#1568](deephaven/web-client-ui#1568)) ([ed8f4b7](deephaven/web-client-ui@ed8f4b7))
* web-client-ui changes required for deephaven.ui ([#1567](deephaven/web-client-ui#1567)) ([94ab25c](deephaven/web-client-ui@94ab25c))
* Widget plugins ([#1564](deephaven/web-client-ui#1564)) ([94cc82c](deephaven/web-client-ui@94cc82c)), closes [#1455](deephaven/web-client-ui#1455) [#1167](deephaven/web-client-ui#1167)


### BREAKING CHANGES

- `usePlugins` and `PluginsContext` were moved from
`@deephaven/app-utils` to `@deephaven/plugin`.
- `useLoadTablePlugin` was moved from `@deephaven/app-utils` to
`@deephaven/dashboard-core-plugins`.
- `useConnection` and `ConnectionContext` were moved from
`@deephaven/app-utils` to `@deephaven/jsapi-components`.
- `DeephavenPluginModuleMap` was removed from `@deephaven/redux`. Use
`PluginModuleMap` from `@deephaven/plugin` instead.
* Enterprise will need ThemeProvider for the css
variables to be available





Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grpc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant