Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjusted Monaco "white" colors #1594

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Oct 20, 2023

This fixes some Monaco suggestion colors

image

fixes #1592

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f440a38) 46.65% compared to head (8101f9f) 46.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1594   +/-   ##
=======================================
  Coverage   46.65%   46.65%           
=======================================
  Files         575      575           
  Lines       36189    36189           
  Branches     9063     9063           
=======================================
  Hits        16883    16883           
  Misses      19254    19254           
  Partials       52       52           
Flag Coverage Δ
unit 46.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/console/src/monaco/MonacoUtils.ts 57.39% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context for @dsmmcken the colors that can be modified are the blue letters in the highlighted selection (1st item), blue in the non-highlighted, white in highlighted, white in non-highlighted. This sets highlighted and non-highlighted to be the same for both colors

@bmingles bmingles merged commit c736708 into deephaven:main Oct 23, 2023
6 checks passed
@bmingles bmingles deleted the 1592-monaco-theme-color-fixes branch October 23, 2023 19:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monaco autocomplete colors are incorrect
3 participants