Skip to content

Commit

Permalink
fix: Adjusted Monaco "white" colors (#1594)
Browse files Browse the repository at this point in the history
This fixes some Monaco suggestion colors

<img width="486" alt="image"
src="https://github.com/deephaven/web-client-ui/assets/1900643/8e550d37-5da5-4e9f-a5c4-1ea95a2e5c0b">

fixes #1592
  • Loading branch information
bmingles authored Oct 23, 2023
1 parent f440a38 commit c736708
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,11 @@
/* Suggest */
--dh-color-editor-suggest-bg: var(--dh-color-gray-200);
--dh-color-editor-suggest-border: var(--dh-color-gray-400);
--dh-color-editor-suggest-fg: var(--dh-color-gray-100);
--dh-color-editor-suggest-fg: var(--dh-color-white);
--dh-color-editor-suggest-selected-bg: var(--dh-color-highlight-selected);
--dh-color-editor-suggest-selected-fg: var(--dh-color-white);
--dh-color-editor-suggest-highlight-fg: var(--dh-color-accent-700);
--dh-color-editor-suggest-focus-highlight-fg: var(--dh-color-accent-700);
--dh-color-editor-suggest-hover-bg: var(--dh-color-highlight-hover);

/* Links */
Expand Down
6 changes: 6 additions & 0 deletions packages/console/src/monaco/MonacoTheme.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,15 @@
editor-suggest-widget-selected-background: var(
--dh-color-editor-suggest-selected-bg
);
editor-suggest-widget-selected-foreground: var(
--dh-color-editor-suggest-selected-fg
);
editor-suggest-widget-highlightForeground: var(
--dh-color-editor-suggest-highlight-fg
);
editor-suggest-widget-focus-highlight-foreground: var(
--dh-color-editor-suggest-focus-highlight-fg
);
list-hover-background: var(--dh-color-editor-suggest-hover-bg);

// links
Expand Down
4 changes: 4 additions & 0 deletions packages/console/src/monaco/MonacoUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,12 @@ class MonacoUtils {
MonacoTheme['editor-suggest-widget-foreground'],
'editorSuggestWidget.selectedBackground':
MonacoTheme['editor-suggest-widget-selected-background'],
'editorSuggestWidget.selectedForeground':
MonacoTheme['editor-suggest-widget-selected-foreground'],
'editorSuggestWidget.highlightForeground':
MonacoTheme['editor-suggest-widget-highlightForeground'],
'editorSuggestWidget.focusHighlightForeground':
MonacoTheme['editor-suggest-widget-focus-highlight-foreground'],
'list.hoverBackground': MonacoTheme['list-hover-background'],
'dropdown.background': MonacoTheme['context-menu-background'],
'dropdown.foreground': MonacoTheme['context-menu-foreground'],
Expand Down

0 comments on commit c736708

Please sign in to comment.