Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashboard plugins to advertise what type of objects they support #1167

Closed
Tracked by #1435
mofojed opened this issue Mar 22, 2023 · 2 comments · Fixed by #1564
Closed
Tracked by #1435

Allow dashboard plugins to advertise what type of objects they support #1167

mofojed opened this issue Mar 22, 2023 · 2 comments · Fixed by #1564
Assignees
Labels
enhancement New feature or request

Comments

@mofojed
Copy link
Member

mofojed commented Mar 22, 2023

As a user, I want plugins to be able to advertise what objects they support opening so that the UI can be smart about display those object types. Should be able to include a friendly name of the object and icon as well (for descriptions).

Currently, if there's an unknown object type exported (such as PartitionedTable), it appears as a button like other objects but just doesn't do anything: #1143

@mofojed mofojed added enhancement New feature or request triage Issue requires triage labels Mar 22, 2023
@vbabich vbabich added this to the April 2023 milestone Mar 22, 2023
@vbabich vbabich removed the triage Issue requires triage label Mar 22, 2023
@mofojed mofojed modified the milestones: April 2023, June 2023 Jun 13, 2023
@mofojed
Copy link
Member Author

mofojed commented Jul 21, 2023

We could also do some sort of ObjectPlugin that just maps a panel to an object, instead of making a whole DashboardPlugin.

@mofojed
Copy link
Member Author

mofojed commented Aug 14, 2023

As we get into programmatic layouts, the plugins we build here should be compatible. To that end, I'm thinking there should actually just be a WidgetPlugin that can advertise it's type, and instead of rendering a whole panel, it just renders the component itself. Panels can then be created/managed programmatically.

@mofojed mofojed modified the milestones: August 2023, September 2023 Sep 11, 2023
@mattrunyon mattrunyon mentioned this issue Oct 10, 2023
2 tasks
mattrunyon added a commit that referenced this issue Oct 19, 2023
Fixes #1455
Fixes #1167 by allowing widget plugins to advertise their supported
types
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Oct 25, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.51.0

# [0.51.0](deephaven/web-client-ui@v0.50.0...v0.51.0) (2023-10-24)


### Bug Fixes

* Adjusted Monaco "white" colors ([#1594](deephaven/web-client-ui#1594)) ([c736708](deephaven/web-client-ui@c736708)), closes [#1592](deephaven/web-client-ui#1592)
* cap width of columns with long names ([#1574](deephaven/web-client-ui#1574)) ([876a6ac](deephaven/web-client-ui@876a6ac)), closes [#1276](deephaven/web-client-ui#1276)
* Enabled pointer capabilities for Firefox in Playwright ([#1589](deephaven/web-client-ui#1589)) ([f440a38](deephaven/web-client-ui@f440a38)), closes [#1588](deephaven/web-client-ui#1588)
* Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list ([#1596](deephaven/web-client-ui#1596)) ([7b59763](deephaven/web-client-ui@7b59763)), closes [#1593](deephaven/web-client-ui#1593)
* Tab in console input triggers autocomplete instead of indent ([#1591](deephaven/web-client-ui#1591)) ([fbe1e70](deephaven/web-client-ui@fbe1e70))


### Features

* Theming - Spectrum Provider ([#1582](deephaven/web-client-ui#1582)) ([a4013c0](deephaven/web-client-ui@a4013c0)), closes [#1543](deephaven/web-client-ui#1543)
* Theming Iris Grid ([#1568](deephaven/web-client-ui#1568)) ([ed8f4b7](deephaven/web-client-ui@ed8f4b7))
* web-client-ui changes required for deephaven.ui ([#1567](deephaven/web-client-ui#1567)) ([94ab25c](deephaven/web-client-ui@94ab25c))
* Widget plugins ([#1564](deephaven/web-client-ui#1564)) ([94cc82c](deephaven/web-client-ui@94cc82c)), closes [#1455](deephaven/web-client-ui#1455) [#1167](deephaven/web-client-ui#1167)


### BREAKING CHANGES

- `usePlugins` and `PluginsContext` were moved from
`@deephaven/app-utils` to `@deephaven/plugin`.
- `useLoadTablePlugin` was moved from `@deephaven/app-utils` to
`@deephaven/dashboard-core-plugins`.
- `useConnection` and `ConnectionContext` were moved from
`@deephaven/app-utils` to `@deephaven/jsapi-components`.
- `DeephavenPluginModuleMap` was removed from `@deephaven/redux`. Use
`PluginModuleMap` from `@deephaven/plugin` instead.
* Enterprise will need ThemeProvider for the css
variables to be available





Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants