Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to upgrade guides for 1.4 #2646

Merged
merged 94 commits into from
Jan 11, 2023
Merged

Updates to upgrade guides for 1.4 #2646

merged 94 commits into from
Jan 11, 2023

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Jan 4, 2023 •
edited
Loading

Description & motivation

Adding the new Core 1.4 upgrade/migration page.
Rename the Upgrade files to insert 1.4 into the menu
Retaining the deprecated versions for the time being. Users may still require to upgrade to new(er) versions based on our messaging and .20/1 deprecation.

Updates to .js files are done as part of #2534

NEED TO COMPLETE REDIRECTS

To-do before merge

  • Complete the upgrade guide for 1.4

If you removed existing pages (delete if not applicable):

  • The page has been removed from website/sidebars.js
  • An entry has been added to _redirects
  • Run link testing to update the links that point to the deleted page

@matthewshaver matthewshaver requested a review from a team as a code owner January 4, 2023 02:39
@matthewshaver matthewshaver self-assigned this Jan 4, 2023
@netlify
Copy link

netlify bot commented Jan 4, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 3586d41
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/63bef5023820d90009c976c5
😎 Deploy Preview https://deploy-preview-2646--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides labels Jan 4, 2023
@matthewshaver matthewshaver added dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) and removed content Improvements or additions to content guides Knowledge best suited for Guides labels Jan 4, 2023
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Jan 4, 2023
@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides labels Jan 4, 2023
@matthewshaver matthewshaver marked this pull request as draft January 4, 2023 02:41
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Jan 4, 2023
@matthewshaver matthewshaver requested a review from jtcohen6 January 4, 2023 02:42
@matthewshaver matthewshaver changed the title Adding/Revising upgrade page titles to acccomodate Updates to upgrade guides for 1.4 Jan 4, 2023
@matthewshaver matthewshaver linked an issue Jan 4, 2023 that may be closed by this pull request
Initiatilize v1.4 [first beta] #2427
Closed
1 task
jtcohen6
jtcohen6 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (pending addition of redirect for page rename)

website/docs/guides/migration/versions/04-upgrading-to-v1.4.md Outdated Show resolved Hide resolved
jtcohen6
jtcohen6 previously requested changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one change - since v1.4 hasn't yet had its final release, let's not yet call v1.4 "latest," or deprive v1.3 of its ongoing claim to being "latest"

website/docs/guides/migration/versions/05-upgrading-to-v1.3.md Outdated
@@ -1,5 +1,5 @@
---
title: "Upgrading to v1.3 (latest)"
title: "Upgrading to v1.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing: We leave "latest" here until v1.4 has its actual-factual final release, which will be in ~3 weeks

website/docs/guides/migration/versions/04-upgrading-to-v1.4.md Outdated Show resolved Hide resolved
mirnawong1
mirnawong1 previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved @matthewshaver !

This was referenced Jan 11, 2023
Merged
Merged
@matthewshaver
Merge pull request #2662 from dbt-labs/manifest-json
f7e66fd 
Updating to address current manifest schema V#
@matthewshaver
Merge pull request #2660 from dbt-labs/python-311
3b786fb 
Updating supported Python version
@matthewshaver
Merge pull request #2659 from dbt-labs/sprocs
6009221 
Updating information about Snowflake sprocs
@matthewshaver
Merge pull request #2658 from dbt-labs/md5-jinja
324a1ce 
Adding new context method local_md5  for v1.4
@matthewshaver
Merge pull request #2657 from dbt-labs/exposures
d21e957 
Exposures support for metrics in Core v1.4
@matthewshaver
Merge pull request #2676 from dbt-labs/defer
f5d8550 
favor-state option support for --defer
@matthewshaver
Merge pull request #2678 from dbt-labs/tarball
929ffc4 
Support for tarball URLs
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Jan 11, 2023
nghi-ly
nghi-ly reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! i've only looked at the prs individually. it's really cool to see it all together! thank you!

left a few comments

website/docs/docs/build/packages.md Outdated Show resolved Hide resolved
website/docs/reference/node-selection/defer.md Outdated Show resolved Hide resolved
@matthewshaver matthewshaver requested a review from nghi-ly January 11, 2023 17:24
matthewshaver and others added 2 commits January 11, 2023 12:25
@matthewshaver @nghi-ly
Update website/docs/docs/build/packages.md
9ff540f 
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
@matthewshaver @nghi-ly
Update website/docs/reference/node-selection/defer.md
090fcb0 
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
nghi-ly
nghi-ly previously approved these changes Jan 11, 2023
View reviewed changes
@nghi-ly nghi-ly dismissed jtcohen6’s stale review January 11, 2023 17:44

sugg was incorporated

@nghi-ly nghi-ly merged commit bf17d4c into current Jan 11, 2023
@nghi-ly nghi-ly deleted the core-1-dot-4 branch January 11, 2023 17:47
@jtcohen6 jtcohen6 mentioned this pull request Jan 12, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@runleonarun runleonarun Awaiting requested review from runleonarun

@mirnawong1 mirnawong1 Awaiting requested review from mirnawong1

Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
dbt Core v1.4 documentation
Development

Successfully merging this pull request may close these issues.

Initiatilize v1.4 [first beta]
5 participants
@matthewshaver @mirnawong1 @jtcohen6 @nghi-ly @runleonarun