Update events-logs docs for v1.4 #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
content
jtcohen6
force-pushed
the
jerco/events-logs-1.4
branch
from
d7dee7d to
0872eb7
Compare
This reverts commit 0872eb7.
| @@ -100,6 +182,10 @@ If available, `node_info` will include: | |||
|
|
|||
| ## Python interface | |||
|
|
|||
| :::warning | |||
There was a problem hiding this comment.
Should we preserve this warning for the v1.4 docs?
There was a problem hiding this comment.
I went back and forth on this, but ultimately I agree - better safe than sorry. I switched around the version blocks so that this section keeps appearing for v1.4+
matthewshaver
previously approved these changes
Jan 13, 2023
|
Merging with @matthewshaver's approval. (I guess pushing a new commit "dismisses" the review?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2639
resolves #2632
What are you changing in this pull request and why?
Update docs on "Events and logs" to reflect meaningful architectural + user-facing changes in v1.4
Checklist
Uncomment if you're publishing docs for a prerelease version of dbt (delete if not applicable):