Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new context method local_md5 for v1.4 #2658

Merged
merged 12 commits into from
Jan 11, 2023
Merged

Adding new context method local_md5 for v1.4 #2658

merged 12 commits into from
Jan 11, 2023

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Jan 5, 2023 •
edited
Loading

What are you changing in this pull request and why?

Adding new Jinja context method for Core v1.4

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry _redirects
  • Ran link testing to update the links that point to the deleted page

@matthewshaver matthewshaver requested a review from a team as a code owner January 5, 2023 03:16
@netlify
Copy link

netlify bot commented Jan 5, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit ec136ae
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/63bde5b1697ed0000b7b106c
😎 Deploy Preview https://deploy-preview-2658--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jan 5, 2023
@matthewshaver matthewshaver linked an issue Jan 5, 2023 that may be closed by this pull request
New dbt-Jinja context method: local_md5 #2637
Closed
1 task
@matthewshaver matthewshaver self-assigned this Jan 5, 2023
@matthewshaver matthewshaver requested a review from jtcohen6 January 5, 2023 03:22
@matthewshaver matthewshaver added the dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) label Jan 5, 2023
jtcohen6
jtcohen6 reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per usual, this will also want a note in the v1.4 migration guide (linking to this page), as soon as the guide exists (#2646)

website/docs/reference/dbt-jinja-functions/local_md5.md Outdated
title: "local_md5"
id: "local_md5"
---
<Changelog>New in 1.4.0</Changelog>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use these <Changelog> entries any more. This system predated the introduction of versioned pages + VersionBlock, with the intent of replacing it entirely.

Instead, we should add this page to the exports.versionedPages list, with "firstVersion": "1.4". That requires having added v1.4 to the exports.versions list, as described in #2427. (It looks like that change is missing from #2646.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. I'll get the export.versions list updated as part of #2534

website/docs/reference/dbt-jinja-functions/local_md5.md Outdated Show resolved Hide resolved
website/docs/reference/dbt-jinja-functions/local_md5.md Outdated Show resolved Hide resolved
runleonarun
runleonarun reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt! I made some minor wording suggestions. Hope they make sense!

website/docs/reference/dbt-jinja-functions/local-md5.md Outdated Show resolved Hide resolved
@jtcohen6 jtcohen6 mentioned this pull request Jan 10, 2023
Merged
4 tasks
@matthewshaver @runleonarun
Update website/docs/reference/dbt-jinja-functions/local-md5.md
1b00b6c 
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
nghi-ly
nghi-ly reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left a couple suggs

website/docs/reference/dbt-jinja-functions/local-md5.md Outdated Show resolved Hide resolved
website/docs/reference/dbt-jinja-functions/local-md5.md Outdated Show resolved Hide resolved
nghi-ly and others added 3 commits January 10, 2023 14:08
@nghi-ly
Merge branch 'current' into md5-jinja
53208e6
@matthewshaver @nghi-ly
Update website/docs/reference/dbt-jinja-functions/local-md5.md
059a74d 
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
@matthewshaver @nghi-ly
Update website/docs/reference/dbt-jinja-functions/local-md5.md
ec136ae 
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
nghi-ly
nghi-ly approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewshaver matthewshaver changed the base branch from current to core-1-dot-4 January 11, 2023 01:59
@matthewshaver matthewshaver merged commit 324a1ce into core-1-dot-4 Jan 11, 2023
@matthewshaver matthewshaver deleted the md5-jinja branch January 11, 2023 16:29
@jtcohen6 jtcohen6 mentioned this pull request Jan 12, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 left review comments

@runleonarun runleonarun runleonarun left review comments

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
dbt Core v1.4 documentation
Development

Successfully merging this pull request may close these issues.

New dbt-Jinja context method: local_md5
5 participants
@matthewshaver @runleonarun @jtcohen6 @nghi-ly @mirnawong1