Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to address current manifest schema V# #2662

Merged
merged 9 commits into from
Jan 11, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding updated version content for the manifest schemas - changing current version to v7 for 1.3 and lower and v8 for 1.4

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry _redirects
  • Ran link testing to update the links that point to the deleted page

@matthewshaver matthewshaver requested a review from a team as a code owner January 5, 2023 19:43
@matthewshaver matthewshaver self-assigned this Jan 5, 2023
@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 6051a0c
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/63bdf73a611f1200084260b8
😎 Deploy Preview https://deploy-preview-2662--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@matthewshaver matthewshaver added the dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) label Jan 5, 2023
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 5, 2023
@matthewshaver matthewshaver linked an issue Jan 5, 2023 that may be closed by this pull request
1 task
@matthewshaver
Copy link
Contributor Author

@jtcohen6 Would it be preferable to version block the Resource Details section to hide root_path for 1.4+ or simply add a note that it has been deprecated from 1.4+ beside the text?

Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI that https://schemas.getdbt.com/dbt/manifest/v8/index.html will be present as soon as we add it (dbt-labs/schemas.getdbt.com#16).

simply add a note that it has been deprecated from 1.4+ beside the text?

I'm happy with a deprecation note. Something like: "Note: Removed in dbt Core v1.4 / manifest v8, to reduce duplicative information across nodes."

Note: Once the v1.4 migration guide exists (#2646), we'll also want some notes under "What to know before upgrading," related to the metadata changes described in #2424.

website/docs/reference/artifacts/manifest-json.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, @jtcohen6 ! i agree that "Current" becomes misleading.

@matthewshaver : can you add this change to the v1.4 project page? i think it only mentions the task of removing versionblocks so it'll be good to capture this in our plans.

Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jan 10, 2023
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left one comment

website/docs/reference/artifacts/manifest-json.md Outdated Show resolved Hide resolved
nghi-ly and others added 2 commits January 10, 2023 13:47
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
@matthewshaver matthewshaver changed the base branch from current to core-1-dot-4 January 11, 2023 01:51
@matthewshaver matthewshaver mentioned this pull request Jan 25, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.4] Manifest v8: reflect changes from node cleanup
4 participants