-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to address current manifest schema V# #2662
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@jtcohen6 Would it be preferable to version block the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI that https://schemas.getdbt.com/dbt/manifest/v8/index.html will be present as soon as we add it (dbt-labs/schemas.getdbt.com#16).
simply add a note that it has been deprecated from 1.4+ beside the text?
I'm happy with a deprecation note. Something like: "Note: Removed in dbt Core v1.4 / manifest v8, to reduce duplicative information across nodes."
Note: Once the v1.4 migration guide exists (#2646), we'll also want some notes under "What to know before upgrading," related to the metadata changes described in #2424.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, @jtcohen6 ! i agree that "Current" becomes misleading.
@matthewshaver : can you add this change to the v1.4 project page? i think it only mentions the task of removing versionblocks so it'll be good to capture this in our plans.
Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! left one comment
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
What are you changing in this pull request and why?
Adding updated version content for the manifest schemas - changing current version to v7 for 1.3 and lower and v8 for 1.4
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js
Removing or renaming existing pages (delete if not applicable):
website/sidebars.js
_redirects