Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert addition of VersionBlocks to Manifest page #2755

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jan 25, 2023

What are you changing in this pull request and why?

Currently, this page is rendering like this:

image

After reverting, it will look like this:

image

I believe this issue was introduced in #2662 and can be seen in the preview for that PR here.

My PR will merely restore the earlier formatting prior to the VersionBlocks being added. Someone else should follow-up with another PR that re-introduces the (helpful!) behavior intended by #2662.

Checklist

  • Visually confirmed behavior using the Netlify Preview here

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit ef78962
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/63d13021c7277d000830ac6d
😎 Deploy Preview https://deploy-preview-2755--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jan 25, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review January 25, 2023 13:51
@dbeatty10 dbeatty10 requested a review from a team as a code owner January 25, 2023 13:51
@dbeatty10 dbeatty10 merged commit ee54161 into current Jan 25, 2023
@dbeatty10 dbeatty10 deleted the dbeatty/revert-manifest-versionblocks branch January 25, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant