Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.4] Manifest v8: reflect changes from node cleanup #2424

Closed
1 task done
jtcohen6 opened this issue Nov 21, 2022 · 1 comment · Fixed by #2662
Closed
1 task done

[v1.4] Manifest v8: reflect changes from node cleanup #2424

jtcohen6 opened this issue Nov 21, 2022 · 1 comment · Fixed by #2662
Assignees
Labels
content Improvements or additions to content dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@jtcohen6
Copy link
Collaborator

jtcohen6 commented Nov 21, 2022

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

What part(s) of the page would you like to see updated?

Top of manifest page: v8 (text + link)

Notes:

  • We still need to generate the v8 schema + add it to schemas.getdbt.com (Add schema for manifest v8 schemas.getdbt.com#16)
  • The page currently says + links to v6 — it should be v7!
  • ❓ Should this part of the page use VersionBlock, to show the corresponding manifest version for the dbt-core version selected in the dropdown?? Maybe — that might be more work than this is worth

Then, in the migration guide, we should add a note similar to the one we've had for past versions:

For consumers of dbt artifacts (metadata)

The manifest schema version has updated to v8. The relevant changes are...

These changes are relevant for users who:

  • parse/analyze contents of manifest.json
  • have custom code accessing the model or graph variables. For example:
{{ model.root_path }}

Relevant changes:

  • root_path removed for all nodes
  • remove some irrelevant/unused attributes from seed nodes, including depends_on
  • macros no longer have tags
  • docs blocks unique IDs now start with doc (consistency!)

Additional information

dbt-labs/dbt-core#6172
dbt-labs/dbt-core#6427

@jtcohen6 jtcohen6 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear idea Proposes an idea for new content dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) labels Nov 21, 2022
@jtcohen6 jtcohen6 changed the title root_path removed from node objects Reflect changes from node cleanup in v1.4 Jan 2, 2023
@jtcohen6 jtcohen6 changed the title Reflect changes from node cleanup in v1.4 [v1.4] Manifest v8: reflect changes from node cleanup Jan 4, 2023
@matthewshaver matthewshaver linked a pull request Jan 5, 2023 that will close this issue
7 tasks
@jtcohen6
Copy link
Collaborator Author

resolved by #2662 + #2646

@runleonarun runleonarun removed the idea Proposes an idea for new content label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants