Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.29.0 #2838

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Release 1.29.0 #2838

merged 6 commits into from
Oct 26, 2023

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Oct 25, 2023

Changes

This PR tracks the release of version 1.29.0 of the Terraform Provider for Databricks.

Release notes:
New Features and Improvements:

Bugfixes:

Exporter:

Documentation changes:

  • Added account_id parameter to provider blocks in the guides (#2817).
  • Changed CREATE_TABLE to CREATE_EXTERNAL_TABLE (#2812).
  • Corrected max number of pinned clusters in the databricks_cluster docs (#2825).
  • Put empty_result_state under options in the databricks_sql_alert resource (#2834).
  • Corrected grammar & rewording for better readability (part 1) (#2781).

Internal changes:

  • Added additional integration tests for condition_task tasks in databricks_job (#2830).
  • Bump github.com/databricks/databricks-sdk-go from 0.23.0 to 0.24.0 (#2835).
  • Bump github.com/hashicorp/hcl/v2 from 2.18.1 to 2.19.1 (#2819).
  • Enabled Cluster Integration test (#2815).
  • Changed Jobs List operations to use token-based pagination (#2810).

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht requested review from a team as code owners October 25, 2023 14:08
@mgyucht mgyucht requested review from tanmay-db and removed request for a team October 25, 2023 14:08
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And release notes in Changelog?

@mgyucht
Copy link
Contributor Author

mgyucht commented Oct 25, 2023

@alexott Yes, was going to get that from the nightly test run since several changes merged today.

@codecov-commenter
Copy link

Codecov Report

Merging #2838 (d07d10c) into master (b60be7b) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   84.38%   84.36%   -0.03%     
==========================================
  Files         152      152              
  Lines       13315    13323       +8     
==========================================
+ Hits        11236    11240       +4     
- Misses       1464     1467       +3     
- Partials      615      616       +1     
Files Coverage Δ
common/version.go 80.00% <ø> (ø)
common/reflect_resource.go 85.77% <50.00%> (-0.63%) ⬇️

@mgyucht
Copy link
Contributor Author

mgyucht commented Oct 25, 2023

There is currently a regression that was introduced by #2753. We're trying to see if we can fix this, but if we can't we'll revert to unblock the release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need to remove this as well...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, I'll undo that change after the revert PR merges and update the changelog

@mgyucht mgyucht disabled auto-merge October 26, 2023 09:29
@mgyucht mgyucht added this pull request to the merge queue Oct 26, 2023
@mgyucht mgyucht removed this pull request from the merge queue due to a manual request Oct 26, 2023
@mgyucht mgyucht added this pull request to the merge queue Oct 26, 2023
Merged via the queue into master with commit 9f55e5b Oct 26, 2023
7 checks passed
@mgyucht mgyucht deleted the prepare/1.29.0 branch October 26, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants