Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that Exporter is experimental #2816

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Specify that Exporter is experimental #2816

merged 1 commit into from
Oct 19, 2023

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Oct 18, 2023

Changes

Exporter is experimental and although we mention that in https://registry.terraform.io/providers/databricks/databricks/latest/docs/guides/experimental-exporter but we don't have mention of that in our repository. Adding message.

Tests

Ran: ./terraform-provider-databricks exporter and Warning is printed.
image

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@tanmay-db tanmay-db requested review from a team as code owners October 18, 2023 16:43
@tanmay-db tanmay-db requested review from mgyucht and alexott and removed request for a team October 18, 2023 16:43
@codecov-commenter
Copy link

Codecov Report

Merging #2816 (61668c7) into master (6b898aa) will decrease coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
- Coverage   84.75%   84.69%   -0.07%     
==========================================
  Files         150      150              
  Lines       13088    13106      +18     
==========================================
+ Hits        11093    11100       +7     
- Misses       1394     1406      +12     
+ Partials      601      600       -1     
Files Coverage Δ
exporter/command.go 82.22% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for @alexott to review as well before merging.

@tanmay-db tanmay-db added this pull request to the merge queue Oct 19, 2023
Merged via the queue into databricks:master with commit c0a5d9f Oct 19, 2023
7 checks passed
@tanmay-db tanmay-db deleted the exporterWarning branch October 19, 2023 12:07
@mgyucht mgyucht mentioned this pull request Oct 25, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants