Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: correct grammar & rewording for better readability (part 1) #2781

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Documentation: correct grammar & rewording for better readability (part 1) #2781

merged 1 commit into from
Oct 19, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Oct 9, 2023

Changes

Started to go through all the documents and fix grammar, etc.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners October 9, 2023 10:29
@alexott alexott requested review from mgyucht and removed request for a team October 9, 2023 10:29
@alexott alexott added the docs add explicit documentation about corner case label Oct 13, 2023
mgyucht
mgyucht approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine to me, just a couple questions/suggestions, then feel free to click merge.

docs/guides/aws-e2-firewall-hub-and-spoke.md Outdated Show resolved Hide resolved
docs/guides/aws-e2-firewall-hub-and-spoke.md Outdated Show resolved Hide resolved
docs/guides/aws-e2-firewall-hub-and-spoke.md Outdated Show resolved Hide resolved
docs/guides/azure-private-link-workspace-simplified.md Outdated Show resolved Hide resolved
docs/guides/azure-private-link-workspace-standard.md Outdated Show resolved Hide resolved
@alexott alexott added this pull request to the merge queue Oct 19, 2023
Merged via the queue into master with commit 6f70477 Oct 19, 2023
7 checks passed
@alexott alexott deleted the docs-grammar-checks-1 branch October 19, 2023 09:11
@mgyucht mgyucht mentioned this pull request Oct 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
docs add explicit documentation about corner case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexott @mgyucht