Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition tasks tests #2830

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add condition tasks tests #2830

merged 1 commit into from
Oct 25, 2023

Conversation

geekswaroop
Copy link
Contributor

@geekswaroop geekswaroop commented Oct 23, 2023 •
edited by mgyucht
Loading

Changes

Condition task terraform support was provided with #2459.

Adding provider integration tests to verify it's working

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@geekswaroop geekswaroop requested review from a team as code owners October 23, 2023 08:48
@geekswaroop geekswaroop requested review from mgyucht and dvkuznietsov and removed request for a team October 23, 2023 08:48
dvkuznietsov
dvkuznietsov reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@dvkuznietsov dvkuznietsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I defer to DECO team

mgyucht
mgyucht approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to add more tests!

@mgyucht mgyucht added this pull request to the merge queue Oct 25, 2023
Merged via the queue into databricks:master with commit 034f1a3 Oct 25, 2023
7 checks passed
@mgyucht mgyucht mentioned this pull request Oct 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@dvkuznietsov dvkuznietsov dvkuznietsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekswaroop @mgyucht @dvkuznietsov