Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter: clarify behaviour of services not marked with listing #2785

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Exporter: clarify behaviour of services not marked with listing #2785

merged 1 commit into from
Oct 19, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Oct 10, 2023

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners October 10, 2023 07:55
@alexott alexott requested review from mgyucht and removed request for a team October 10, 2023 07:55
@alexott alexott added docs add explicit documentation about corner case exporter TF configuration generator labels Oct 13, 2023
nkvuong
nkvuong approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - although there is a merge conflict to resolve

@alexott alexott force-pushed the exporter-docs-clarify-storage branch from 8d4cf5c to 343dca8 Compare October 18, 2023 12:23
@alexott
Copy link
Contributor Author

alexott commented Oct 18, 2023

conflicts are fixed

@mgyucht mgyucht added this pull request to the merge queue Oct 19, 2023
Merged via the queue into master with commit 0751901 Oct 19, 2023
7 checks passed
@mgyucht mgyucht deleted the exporter-docs-clarify-storage branch October 19, 2023 08:03
@mgyucht mgyucht mentioned this pull request Oct 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@nkvuong nkvuong nkvuong approved these changes

Assignees
No one assigned
Labels
docs add explicit documentation about corner case exporter TF configuration generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexott @mgyucht @nkvuong