forked from openscd/open-scd
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from v0.25.0 of OpenSCD into CoMPAS OpenSCD #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1014) Co-authored-by: Dennis Labordus <dennis.labordus@alliander.com>
…penscd#1006. (openscd#1007) * Add ? and * wildcards to filtered-search, closes openscd#1006. * Ensure wildcard matches at least one character, add tests * Add documentation * Improve algorithm and refactor * Review comments, split on regex for multiple spaces
* Small improvements in tests * Small improvements in tests
* Browser recommondation * typo fix
… binding subscription (openscd#1026) * Resolve absent prefix in ExtRef for later binding subscription, part of openscd#1005 * Correct approach from review feedback * Add tests * Update snapshots * Tidy up, update snapshots, update tests
…OOSE/SMV) (openscd#1036) * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button + renaming other subscriber plugins * Fixed plugin test * Show connected and available LN + small fixes * Processed review comments.
…ical Nodes (GOOSE/SMV) (openscd#1039) * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button + renaming other subscriber plugins * Fixed plugin test * Show connected and available LN + small fixes * First version of subscribe and unsubscribe * Added test for subscribing and unsubscribing logica node binding * Processed review comments. * Review comments processed * Fixed tests.
… Nodes / Later) (GOOSE/SMV) (openscd#1040) * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button + renaming other subscriber plugins * Fixed plugin test * Show connected and available LN + small fixes * First version of subscribe and unsubscribe * Added test for subscribing and unsubscribing logica node binding * First step for the counter, refactoring list methods to re-use logic. Also removed sorting. * Added counter logic to both subscriber plugins * Processed review comments. * Changed query to retrieve available LN Classes to match only data binding ExtRefs * Fix performance issue. * Fixed snapshot. * Review comments processed * Fixed tests. * Fixed test.
…ference Attributes (GOOSE/SMV) (openscd#1041) * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button + renaming other subscriber plugins * Fixed plugin test * Show connected and available LN + small fixes * First version of subscribe and unsubscribe * Added test for subscribing and unsubscribing logica node binding * First step for the counter, refactoring list methods to re-use logic. Also removed sorting. * Added counter logic to both subscriber plugins * Processed review comments. * Changed query to retrieve available LN Classes to match only data binding ExtRefs * Fix performance issue. * Fixed snapshot. * Fix bug when selecting ExtRef also include Control References. * Fixed tests. * Review comments processed * Fixed tests. * Fixed test.
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
dlabordus
requested review from
juancho0202,
pascalwilbrink and
JakobVogelsang
October 18, 2022 07:04
pascalwilbrink
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.