-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor/subscriber): Show counter for Subscriber Plugins (Logical Nodes / Later) (GOOSE/SMV) #1040
Conversation
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
…other subscriber plugins Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
… Also removed sorting. Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@danyill, which issue will this PR close? Would be nice to link it to this PR. I think I got all your code from the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing, tidying up and improving my efforts 👏
There is a one liner we must fix as this PR breaks the indexing completely:
- I tested with
IOP_2019_HV_v9_ed2.1.scd
, I found that it takes 5-10 seconds to update when I click on an FCDA in the GOOSE later-binding plugin for every different FCDA I select. - In my branch
issue-958-number-of-connections
it only seems to happen for the first one (as I would expect).
We reset the map where we should not, I have identified the place where it occurs.
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
…ding ExtRefs Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@danyill, can you try again if the performance is better? I fixed the update method. This was indeed needed to make it faster. |
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
LVGTM, thanks! |
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
This will replace PR #993 and closes #958
Thanks @danyill for the code.
It will added the counter to the Left Side of the Editor for both Data and Later Binding.
Through a event the counter will be updated if the subscription changes.