Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor/subscriber): Show counter for Subscriber Plugins (Logical Nodes / Later) (GOOSE/SMV) #1040

Merged
merged 21 commits into from
Oct 13, 2022

Conversation

dlabordus
Copy link
Contributor

@dlabordus dlabordus commented Oct 12, 2022

This will replace PR #993 and closes #958

Thanks @danyill for the code.

It will added the counter to the Left Side of the Editor for both Data and Later Binding.
Through a event the counter will be updated if the subscription changes.

Dennis Labordus added 9 commits October 10, 2022 13:06
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
…other subscriber plugins

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
… Also removed sorting.

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus added the Kind: Enhancement New Request label Oct 12, 2022
@dlabordus dlabordus self-assigned this Oct 12, 2022
@dlabordus
Copy link
Contributor Author

dlabordus commented Oct 12, 2022

@danyill, which issue will this PR close? Would be nice to link it to this PR.

I think I got all your code from the other PR.

@danyill
Copy link
Collaborator

danyill commented Oct 12, 2022

@danyill, which issue will this PR close? Would be nice to link it to this PR.

I think I got all your code from the other PR.

Added to the first comment, #958. Thanks.

Copy link
Collaborator

@danyill danyill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing, tidying up and improving my efforts 👏

There is a one liner we must fix as this PR breaks the indexing completely:

  • I tested with IOP_2019_HV_v9_ed2.1.scd, I found that it takes 5-10 seconds to update when I click on an FCDA in the GOOSE later-binding plugin for every different FCDA I select.
  • In my branch issue-958-number-of-connections it only seems to happen for the first one (as I would expect).

We reset the map where we should not, I have identified the place where it occurs.

Dennis Labordus added 4 commits October 13, 2022 07:26
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
…ding ExtRefs

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus linked an issue Oct 13, 2022 that may be closed by this pull request
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus
Copy link
Contributor Author

@danyill, can you try again if the performance is better?

I fixed the update method. This was indeed needed to make it faster.

@dlabordus dlabordus linked an issue Oct 13, 2022 that may be closed by this pull request
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@danyill
Copy link
Collaborator

danyill commented Oct 13, 2022

LVGTM, thanks!

Dennis Labordus added 2 commits October 13, 2022 11:18
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Base automatically changed from subscriber-ln-goose-actions to main October 13, 2022 14:21
Dennis Labordus added 3 commits October 13, 2022 16:28
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus merged commit 02ec714 into main Oct 13, 2022
@dlabordus dlabordus deleted the subscriber-counter branch October 13, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FCDA order doesn't follow dataset in GOOSE later binding editor Feedback on Later Binding SMV Plugin
2 participants