Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor/subscriber): Added plugin for Subscriber Logical Nodes (GOOSE/SMV) #1036

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

dlabordus
Copy link
Contributor

@dlabordus dlabordus commented Oct 10, 2022

closes #930
closes #931
closes #932
closes #935
closes #936
closes #937

Refactoring of Later Binding Plugins to reuse the FCDA List, not only for Later Binding.

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus added the Kind: Enhancement New Request label Oct 10, 2022
@dlabordus dlabordus self-assigned this Oct 10, 2022
Dennis Labordus added 2 commits October 10, 2022 13:26
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
…other subscriber plugins

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus changed the title feat(editor/subscriber): Added plugin for Subscriber Logical Nodes (GOOSE) feat(editor/subscriber): Added plugin for Subscriber Logical Nodes (GOOSE/SMV) Oct 10, 2022
Dennis Labordus added 2 commits October 10, 2022 15:32
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus marked this pull request as ready for review October 11, 2022 13:54
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is something still incorrect. Also provided translations and some code style bla bla

src/editors/SMVSubscriberDataBinding.ts Outdated Show resolved Hide resolved
src/editors/GooseSubscriberDataBinding.ts Show resolved Hide resolved
src/translations/de.ts Outdated Show resolved Hide resolved
src/translations/de.ts Outdated Show resolved Hide resolved
test/unit/editors/GooseSubscriberDataBinding.test.ts Outdated Show resolved Hide resolved
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabordus dlabordus merged commit 971f0c1 into main Oct 13, 2022
@dlabordus dlabordus deleted the subscriber-ln-goose branch October 13, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment