fix(editors/later-binding): Resolve absent prefix in ExtRef for later binding subscription

[danyill]

Partially resolves #1005

[JakobVogelsang]

Very nice! Thanks for tracing back the issue. Would it be possible to add a regression test?

[danyill]

Please don't merge I must do more here...

…

On Tue, 4 Oct 2022, 18:23 Dennis Labordus, ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#1026 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFEXX6UIYC4BY6UOL6SMBDWBO5NNANCNFSM6AAAAAAQ2JKYXI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[danyill]

Thank you for the review, I understand better now, despite this being quite trivial 😉 😢

In preparing the tests I ran the scd file through OpenSCD which is why there is some whitespace diff.

Without this:

@@ -71,6 +71,9 @@
                                                <Inputs>
                                                        <ExtRef intAddr="Pos;CSWI1/Pos/stVal" desc="Interlocking.Input"/>
                                                        <ExtRef intAddr="Pos;CSWI1/Pos/q" desc="Interlocking.Input" iedName="GOOSE_Publisher" serviceType="GOOSE" ldInst="QB2_Disconnector" lnClass="CSWI" lnInst="1" prefix="" doName="Pos" daName="q" srcLDInst="QB2_Disconnector" srcPrefix="" srcLNClass="LLN0" srcCBName="GOOSE2"/>
+                                                       <ExtRef intAddr="Pos;CILO/EnaOpn/stVal" desc="Interlocking.Input2" iedName="GOOSE_Publisher" serviceType="GOOSE" ldInst="QB1_Disconnector" lnClass="CILO" lnInst="1" prefix="" doName="EnaOpn" daName="stVal" srcLDInst="QB2_Disconnector" srcPrefix="" srcLNClass="LLN0" srcCBName="GOOSE2"/>
+                                                       <ExtRef intAddr="Pos;CILO/EnaCls/stVal" desc="Interlocking.Input3" iedName="GOOSE_Publisher" serviceType="GOOSE" ldInst="QB1_Disconnector" lnClass="CILO" lnInst="1" doName="EnaCls" daName="stVal" srcLDInst="QB2_Disconnector" srcPrefix="" srcLNClass="LLN0" srcCBName="GOOSE2"/>
+                                                       <ExtRef intAddr="Pos;CILO/EnaOpn2/stVal" desc="Interlocking.Input4" iedName="GOOSE_Publisher" serviceType="GOOSE" ldInst="QB2_Disconnector" lnClass="CILO" lnInst="1" doName="EnaOpn" daName="stVal" srcLDInst="QB2_Disconnector" srcPrefix="" srcLNClass="LLN0" srcCBName="GOOSE2"/>
                                                </Inputs>
                                        </LN>
                                        <LN prefix="" lnClass="CSWI" inst="1" lnType="Dummy.CSWI">
@@ -94,6 +97,9 @@
                                                <DataSet name="GOOSE2sDataSet">
                                                        <FCDA ldInst="QB2_Disconnector" prefix="" lnClass="CSWI" lnInst="1" doName="Pos" daName="stVal" fc="ST"/>
                                                        <FCDA ldInst="QB2_Disconnector" prefix="" lnClass="CSWI" lnInst="1" doName="Pos" daName="q" fc="ST"/>
+                                                       <FCDA ldInst="QB1_Disconnector" lnClass="CILO" lnInst="1" doName="EnaOpn" daName="stVal" fc="ST"/>
+                                                       <FCDA ldInst="QB1_Disconnector" prefix="" lnClass="CILO" lnInst="1" doName="EnaCls" daName="stVal" fc="ST"/>
+                                                       <FCDA ldInst="QB2_Disconnector" lnClass="CILO" lnInst="1" doName="EnaOpn" daName="stVal" fc="ST"/>
                                                </DataSet>
                                                <DataSet name="GOOSE1sDataSet">
                                                        <FCDA ldInst="QB1_Disconnector" prefix="" lnClass="CSWI" lnInst="1" doName="Pos" daName="stVal" fc="ST"/>

I have added CILO LN subscriptions with the following combinations, which I think cover the relevant cases.

FCDA        ExtRef
No prefix   Prefix
Prefix      No prefix
No prefix   No prefix