Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(editor/subscriber): When selecting ExtRef also include Control Reference Attributes (GOOSE/SMV) #1041

Merged
merged 26 commits into from
Oct 17, 2022
Merged

bug(editor/subscriber): When selecting ExtRef also include Control Reference Attributes (GOOSE/SMV) #1041

merged 26 commits into from
Oct 17, 2022

Conversation

dlabordus
Copy link
Contributor

When using a newer version than 2003 the ExtRef also include the attributes 'srcLDInst', 'srcLNClass', 'srcLNInst' and 'srcCBName' of the Control Element (SMV/GOOSE) (and ServiceType was also missing).
These attributes were not added when search for a matching ExtRef. So it found a matching ExtRef much faster and then not creating a new ExtRef.

Dennis Labordus added 17 commits October 10, 2022 13:06
Added plugin and show FCDA Elements including edit button
09f31a8 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Added plugin and show FCDA Elements including edit button
48c67c6 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Added plugin and show FCDA Elements including edit button + renaming …
012cc55 
…other subscriber plugins

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Fixed plugin test
56c78aa 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Show connected and available LN + small fixes
36b5381 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
First version of subscribe and unsubscribe
1613047 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Added test for subscribing and unsubscribing logica node binding
320cd18 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
First step for the counter, refactoring list methods to re-use logic.…
494e53c 
… Also removed sorting.

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Added counter logic to both subscriber plugins
ca97dec 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Processed review comments.
d76536a 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Merge branch 'subscriber-ln-goose' into subscriber-ln-goose-actions
69c3d32
Merge branch 'subscriber-ln-goose-actions' into subscriber-counter
1b1ff5f 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Changed query to retrieve available LN Classes to match only data bin…
97825d5 
…ding ExtRefs

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Fix performance issue.
d15e4d0 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Fixed snapshot.
584f3f0 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Fix bug when selecting ExtRef also include Control References.
7b7b0a0 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Merge branch 'main' into subscriber-ln-goose-actions
0de6f9c 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus changed the title feat(editor/subscriber): When selecting ExtRef also include Control References bug(editor/subscriber): When selecting ExtRef also include Control References Oct 13, 2022
@dlabordus dlabordus changed the title bug(editor/subscriber): When selecting ExtRef also include Control References bug(editor/subscriber): When selecting ExtRef also include Control Reference Attributes (GOOSE/SMV) Oct 13, 2022
Fixed tests.
5190590 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus self-assigned this Oct 13, 2022
@dlabordus dlabordus added the Kind: Bug Something isn't working label Oct 13, 2022
@dlabordus dlabordus marked this pull request as ready for review October 13, 2022 10:57
Dennis Labordus added 5 commits October 13, 2022 15:33
Review comments processed
51f85e5 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Fixed tests.
0b3b8af 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Merge branch 'subscriber-ln-goose-actions' into subscriber-counter
1cad767 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Merge branch 'main' into subscriber-counter
727893d 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Fixed test.
c7ddc45 
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Base automatically changed from subscriber-counter to main October 13, 2022 15:30
JakobVogelsang
JakobVogelsang reviewed Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Just have one question. :) Thanks for properly updating the snapshots!

test/integration/editors/__snapshots__/SMVSubscriberMessageBinding.test.snap.js Show resolved Hide resolved
JakobVogelsang
JakobVogelsang approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabordus dlabordus merged commit 4b48f6e into main Oct 17, 2022
@dlabordus dlabordus deleted the subscriber-bugfix branch October 17, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang approved these changes

Assignees

@dlabordus dlabordus

Labels
Kind: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlabordus @JakobVogelsang