Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CICADA/CaloSummary emulation and make CICADA versions available as templated plugins #43091

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

aloeliger
Copy link
Contributor

PR description:

This PR cleans up several poorly formatted elements of the CaloSummary emulator, and makes it's central feature, CICADA, slightly more configurable by making template plugin versions to match the data types for CICADA versions (i.e. CICADA v1 has a plugin version defined by template, CICADA v2 has a different version defined by template, etc.).

This is in preparation to begin moving the CaloSummary emulator into the main L1 sequence, in preparation for further integration downstream.

Relies upon (somewhat, as it is in no standard sequences yet) cms-sw/cmsdist#8781

PR validation:

All code compiles and has had tests run and code formatting applied. As the emulator is not in any standard sequences yet, no changes are expected. A similar version of this code has been running our emulation studies on CICADA for a while.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport. A backport is only foreseen if L1/HLT menu studies are performed on earlier versions of CMSSW.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43091/37326

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aloeliger (Andrew Loeliger) for master.

It involves the following packages:

  • L1Trigger/L1TCaloLayer1 (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor Author

please test with cms-sw/cmsdist#8781

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43091/37327

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43091 was updated. @epalencia, @aloeliger can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc3a48/35362/summary.html
COMMIT: de4e2fb
CMSSW: CMSSW_13_3_X_2023-10-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43091/35362/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc3a48/35362/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc3a48/35362/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357372
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor Author

+l1

  • Not that I'm an unbiased reviewer of my own edits, or when it comes to CICADA, but CICADA does need to start moving towards further integration with the rest of L1 emulation and this slight cleanup should make it a little more palatable (admittedly, there are plenty of other things that could be done).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7d0fde6 into cms-sw:master Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants