Phase2-hgx346B Next step toward calibration cell collection for HGCal in the next version of HGCal geometry replacing #43045

[bsunanda]

PR description:

Next step toward calibration cell collection for HGCal in the next version of HGCal geometry replacing #43045

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43069/37286

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• DataFormats/ForwardDetId (simulation, upgrade)
• Geometry/HGCalCommonData (geometry, upgrade)
• SimG4CMS/Calo (simulation)

@cmsbuild, @Dr15Jones, @makortel, @bsunanda, @srimanob, @mdhildreth, @AdrianoDee, @civanch can you please review it and eventually sign? Thanks.
@felicepantaleo, @thomreis, @ReyerBand, @apsallid, @fabiocos, @wang0jin, @youyingli, @missirol, @rovere, @slomeo this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8295ba/35302/summary.html
COMMIT: 386c7fa
CMSSW: CMSSW_13_3_X_2023-10-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43069/35302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 935 lines to the logs
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1064
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356314
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[bsunanda]

@civanch @srimanob Please approve this PR which is a replacement of an earlier PR

[civanch]

@bsunanda , please, comment out the DEBUG

[bsunanda]

Done

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43069/37299

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #43069 was updated. @AdrianoDee, @makortel, @bsunanda, @srimanob, @civanch, @mdhildreth, @Dr15Jones can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8295ba/35317/summary.html
COMMIT: 7395396
CMSSW: CMSSW_13_3_X_2023-10-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43069/35317/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357372
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1