Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2-hgx346A Next step toward calibration cell collection for HGCal in the next version of HGCal geometry #43045

Closed
wants to merge 5 commits into from
Closed

Phase2-hgx346A Next step toward calibration cell collection for HGCal in the next version of HGCal geometry #43045

wants to merge 5 commits into from

Conversation

bsunanda
Copy link
Contributor

PR description:

Next step toward calibration cell collection for HGCal in the next version of HGCal geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Oct 17, 2023
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43045/37235

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43045/37236

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • DataFormats/ForwardDetId (simulation, upgrade)
  • Geometry/HGCalCommonData (upgrade, geometry)
  • SimG4CMS/Calo (simulation)

@mdhildreth, @srimanob, @Dr15Jones, @civanch, @AdrianoDee, @bsunanda, @makortel can you please review it and eventually sign? Thanks.
@missirol, @felicepantaleo, @rovere, @wang0jin, @slomeo, @apsallid, @thomreis, @ReyerBand, @fabiocos, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fab598/35234/summary.html
COMMIT: 9980019
CMSSW: CMSSW_13_3_X_2023-10-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43045/35234/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1008 lines to the logs
  • Reco comparison results: 2984 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 6123
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3351255
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@civanch
Copy link
Contributor

civanch commented Oct 18, 2023

+1

smuzaffar and others added 2 commits October 19, 2023 17:55
@smuzaffar
Squashed commit of the following:
9fb94ad 
commit 04defae
Author: Shahzad Malik Muzaffar <shahzad.malik.muzaffar@cern.ch>
Date:   Wed Oct 18 14:24:27 2023 +0200

    apply fixes as suggested

commit 5d879b9
Author: Malik Shahzad Muzaffar <shahzad.malik.muzaffar@cern.ch>
Date:   Tue Oct 17 09:17:27 2023 +0200

    added missing: header used by DMRChecker.cc

commit dcc0e24
Author: Shahzad Malik Muzaffar <shahzad.malik.muzaffar@cern.ch>
Date:   Mon Oct 16 23:34:30 2023 +0200

    code format

commit 07c302e
Author: Shahzad Malik Muzaffar <shahzad.malik.muzaffar@cern.ch>
Date:   Mon Oct 16 22:39:27 2023 +0200

    Fix for Werror=return-type wehn compiled with -O0

Co-authored-by: Malik Shahzad Muzaffar <shahzad.malik.muzaffar@cern.ch>\nadded missing: header used by DMRChecker.cc
Modify the tester for parameter and a few scripts to test HGCal geometry
7f96e86
@bsunanda
Copy link
Contributor Author

Couldn't resolve the conflicts.

@bsunanda bsunanda closed this Oct 19, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43045/37282

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43045 was updated. @Dr15Jones, @jfernan2, @saumyaphor4252, @mandrenguyen, @syuvivida, @civanch, @makortel, @nothingface0, @antoniovagnerini, @francescobrivio, @AdrianoDee, @perrotta, @cmsbuild, @mdhildreth, @srimanob, @consuegs, @tjavaid, @rvenditti, @bsunanda can you please check and sign again.

bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Oct 20, 2023
Next step toward calibration cell collection for HGCal in the next ve…
386c7fa 
…rsion of HGCal geometry replacing cms-sw#43045
@bsunanda bsunanda mentioned this pull request Oct 20, 2023
Merged
cmsbuild added a commit that referenced this pull request Oct 23, 2023
@cmsbuild
Merge pull request #43069 from bsunanda/Phase2-hgx346B
1a0e22f 
Phase2-hgx346B Next step toward calibration cell collection for HGCal in the next version of HGCal geometry replacing #43045
RSalvatico pushed a commit to RSalvatico/cmssw that referenced this pull request Nov 24, 2023
@RSalvatico
Next step toward calibration cell collection for HGCal in the next ve…
eb2100c 
…rsion of HGCal geometry replacing cms-sw#43045
zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 14, 2024
Next step toward calibration cell collection for HGCal in the next ve…
d82ed1f 
…rsion of HGCal geometry replacing cms-sw#43045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending code-checks-approved db-pending dqm-pending geometry-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending tracking trk upgrade-pending
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
4 participants
@bsunanda @cmsbuild @civanch @smuzaffar