Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StandaloneTrackerTopology and providing unit tests #43059

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 19, 2023

PR description:

In #43020 (comment) it was noticed that one of the pixel payload inspector tests was very noisy.
In #43020 (comment) is was elucidated that the reason can be traced back to this commit 5af9d66, that - while supplying in TrackerTopology the provision to distinguish in the Phase-2 IT barrel layer 1 two sensors per module - at the same time (since the change in the meaning of the bit masks was not propagated to StandaloneTrackerTopology) it also created a bug in all the clients that at that point started to silently fail correctly parsing the topology from XML.
This is fixed in commit e165f7f.
In this PR I also provide a unit test, to avoid future possible mismatches between the two mechanisms f05c656, as well as some other miscellaneous improvements in the Pixel Payload Inspector suite that were useful during debugging.

PR validation:

Relies on the newly created unit test, scram b runtests_CalibTrackerStandaloneTrackerTopologyTestDriver which runs fine with this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but should be backported down to all the releases in which there is active development.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 19, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43059/37261

  • This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43059/37264

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/StandaloneTrackerTopology (alca)
  • CondCore/SiPixelPlugins (db)

@saumyaphor4252, @consuegs, @perrotta, @cmsbuild, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @ferencek, @mroguljic, @rsreds, @PonIlya, @tvami, @VinInn, @yuanchao, @tocheng this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 19, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ddb73/35289/summary.html
COMMIT: 407a61c
CMSSW: CMSSW_13_3_X_2023-10-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43059/35289/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357375
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Warning messages are not there any more in the unit test outputs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants