-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StandaloneTrackerTopology
and providing unit tests
#43059
Conversation
…e as the Standalone one
type bug-fix |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43059/37261
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
- In the case of the phase-2 IT there is an additional layer of hierarcy, due ot split sensors in Layer 1. First introduced in PR cms-sw#41880
025dcac
to
407a61c
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43059/37264
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@saumyaphor4252, @consuegs, @perrotta, @cmsbuild, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ddb73/35289/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In #43020 (comment) it was noticed that one of the pixel payload inspector tests was very noisy.
In #43020 (comment) is was elucidated that the reason can be traced back to this commit 5af9d66, that - while supplying in
TrackerTopology
the provision to distinguish in the Phase-2 IT barrel layer 1 two sensors per module - at the same time (since the change in the meaning of the bit masks was not propagated toStandaloneTrackerTopology
) it also created a bug in all the clients that at that point started to silently fail correctly parsing the topology from XML.This is fixed in commit e165f7f.
In this PR I also provide a unit test, to avoid future possible mismatches between the two mechanisms f05c656, as well as some other miscellaneous improvements in the Pixel Payload Inspector suite that were useful during debugging.
PR validation:
Relies on the newly created unit test,
scram b runtests_CalibTrackerStandaloneTrackerTopologyTestDriver
which runs fine with this PR.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but should be backported down to all the releases in which there is active development.